This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Adds minVersion to findPackageConfig{,Uri} methods.
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnniwinther
approved these changes
May 20, 2022
lib/src/discovery.dart
Outdated
| /// | ||
| /// If [minVersion] is greated than 1, `.packages` files are ignored. | ||
| /// If [minVersion] is greater than the version read from the | ||
| /// `pacakage_config.json` file, it too is ignored. |
There was a problem hiding this comment.
pacakage_config.json -> package_config.json
This parameter currently allows you to ignore `.packages` files while searching for a configuration file. If we later add a version 3 of the configuration, it should also allow ignoring version 2 configurations.
devoncarew
reviewed
Jun 14, 2022
| @@ -1,4 +1,11 @@ | |||
| ## 2.0.3-dev | |||
| ## 2.1.0 | |||
There was a problem hiding this comment.
Are we ready to publish 2.1.0 now?
lrhn
commented
Jun 15, 2022
| ignoring version 1, aka. `.packages` files.) | ||
|
|
||
| - Changes the version number of `SimplePackageConfig.empty` to the | ||
| current maximum version. | ||
|
|
||
| - Improve file read performance; improve lookup performance. | ||
| - Emit an error when a package is inside the package root of another package. |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
…ckage_config#125) * Adds `minVersion` to `findPackageConfig{,Uri}` methods. This parameter currently allows you to ignore `.packages` files while searching for a configuration file. If we later add a version 3 of the configuration, it should also allow ignoring version 2 configurations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter currently allows you to ignore
.packagesfileswhile searching for a configuration file.
If we later add a version 3 of the configuration, it should
also allow ignoring version 2 configurations.