This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
add test validating current behavior of packageOf, run CI on windows #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the plan @jakemac53 ? |
|
🤷 just waiting for a review, cc @lrhn |
kevmoo
approved these changes
Jan 10, 2024
jakemac53
force-pushed
the
windows-case-sensitivity
branch
from
a1c0b2f to
8d53c8a
Compare
|
Hmm, this is timing out when multiple tests are ran, but not a single test. Ultimately, there is no real need for build_web_compilers/build_runner here, so I am just going to remove that. |
|
I am going to go ahead and land this, given it is just testing current behavior. Whether the behavior should change is separate. |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
…art-lang/package_config#137) - validates the behavior of https://github.com/dart-lang/package_config/issues/136 today (but does not change it) - removes build_runner deps for testing, there is no need to use it for such a small package - fixes a bug in discovery_test.dart that was probably landed due to inability to run tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packageOftools#1545 today (but does not change it)