Version 3.7.0-102.0.dev

Merge 7b9d11a into dev

DEPS

@@ -76,7 +76,7 @@ vars = {
   "jsc_tag": "version:285702",
 
   # https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang
-  "clang_version": "git_revision:3928edecfbd116d56bbe7411365d50bb567380a1",
+  "clang_version": "git_revision:e6549b8036089f20c6ac01e644a544aa2b231ca8",
 
   # https://chrome-infra-packages.appspot.com/p/gn/gn
   "gn_version": "git_revision:feafd1012a32c05ec6095f69ddc3850afb621f3a",
@@ -85,7 +85,7 @@ vars = {
   "download_reclient": True,
 
   # Update from https://chrome-infra-packages.appspot.com/p/fuchsia/sdk/core
-  "fuchsia_sdk_version": "version:24.20240917.7.1",
+  "fuchsia_sdk_version": "version:25.20241104.6.1",
   "download_fuchsia_deps": False,
 
   # Ninja, runs the build based on files generated by GN.
@@ -658,7 +658,7 @@ deps = {
     "packages": [
       {
       "package": "chromium/fuchsia/gn-sdk",
-      "version": "em2Jr5ylJrKKI86rUNPyGXlpTo4qGNTePgT70PDtRT8C",
+      "version": "ArgKhW3O86dFu3jHY4iET_azMrJygzWdDTdvE_AAS2AC",
       }
     ],
     "condition": 'download_fuchsia_deps',

pkg/analysis_server_client/analyzer_use_new_elements.txt

@@ -1,16 +0,0 @@
-example/example.dart
-lib/handler/connection_handler.dart
-lib/handler/notification_handler.dart
-lib/listener/server_listener.dart
-lib/protocol.dart
-lib/server.dart
-lib/src/protocol/protocol_base.dart
-lib/src/protocol/protocol_common.dart
-lib/src/protocol/protocol_constants.dart
-lib/src/protocol/protocol_generated.dart
-lib/src/protocol/protocol_internal.dart
-lib/src/server_base.dart
-test/all.dart
-test/live_test.dart
-test/server_test.dart
-test/verify_sorted_test.dart

pkg/analysis_server_plugin/analyzer_use_new_elements.txt

@@ -1,23 +1,2 @@
-lib/edit/correction_utils.dart
-lib/edit/dart/dart_fix_kind_priority.dart
-lib/edit/fix/fix.dart
-lib/edit/fix/fix_context.dart
-lib/plugin.dart
-lib/registry.dart
-lib/src/correction/change_workspace.dart
-lib/src/correction/dart_change_workspace.dart
-lib/src/correction/fix_generators.dart
-lib/src/correction/fix_in_file_processor.dart
-lib/src/correction/fix_processor.dart
-lib/src/plugin_server.dart
-lib/src/registry.dart
-lib/src/utilities/selection.dart
-test/edit/correction_utils_test.dart
-test/edit/test_all.dart
-test/single_unit.dart
-test/src/lint_rules.dart
-test/src/plugin_server_error_test.dart
-test/src/plugin_server_test.dart
-test/src/plugin_server_test_base.dart
-test/src/test_all.dart
-test/test_all.dart
+lib/edit/dart/correction_producer.dart
+lib/edit/fix/dart_fix_context.dart

pkg/analysis_server_plugin/lib/src/plugin_server.dart

@@ -257,7 +257,8 @@ class PluginServer {
     for (var configuration in analysisOptions.pluginConfigurations) {
       if (!configuration.isEnabled) continue;
       // TODO(srawlins): Namespace rules by their plugin, to avoid collisions.
-      var rules = Registry.ruleRegistry.enabled(configuration.ruleConfigs);
+      var rules =
+          Registry.ruleRegistry.enabled(configuration.diagnosticConfigs);
       for (var rule in rules) {
         rule.reporter = errorReporter;
         var timer = enableTiming ? analysisRuleTimers.getTimer(rule) : null;

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -36,7 +36,7 @@ class PluginServerErrorTest extends PluginServerTestBase {
     newAnalysisOptionsYamlFile(packagePath, '''
 plugins:
   no_bools:
-    rules:
+    diagnostics:
       - no_bools
 ''');
   }

pkg/analysis_server_plugin/test/src/plugin_server_test.dart

@@ -69,7 +69,7 @@ class PluginServerTest extends PluginServerTestBase {
     expect(fixes[0].fixes, hasLength(1));
   }
 
-  Future<void> test_lintRulesAreDisabledByDefault() async {
+  Future<void> test_lintDiagnosticsAreDisabledByDefault() async {
     writeAnalysisOptionsWithPlugin();
     newFile(filePath, 'double x = 3.14;');
     await channel
@@ -81,7 +81,7 @@ class PluginServerTest extends PluginServerTestBase {
     expect(params.errors, isEmpty);
   }
 
-  Future<void> test_lintRulesCanBeEnabled() async {
+  Future<void> test_lintDiagnosticsCanBeEnabled() async {
     writeAnalysisOptionsWithPlugin({'no_doubles': true});
     newFile(filePath, 'double x = 3.14;');
     await channel
@@ -169,7 +169,7 @@ class PluginServerTest extends PluginServerTestBase {
     _expectAnalysisError(params.errors.single, message: 'No bools message');
   }
 
-  Future<void> test_warningRulesAreEnabledByDefault() async {
+  Future<void> test_warningDiagnosticsAreEnabledByDefault() async {
     writeAnalysisOptionsWithPlugin();
     newFile(filePath, 'bool b = false;');
     await channel
@@ -182,9 +182,7 @@ class PluginServerTest extends PluginServerTestBase {
     _expectAnalysisError(params.errors.single, message: 'No bools message');
   }
 
-  Future<void> test_warningRulesCannotBeDisabled() async {
-    // TODO(srawlins): A warning should be reported in the analysis options file
-    // for this.
+  Future<void> test_warningDiagnosticsCanBeDisabled() async {
     writeAnalysisOptionsWithPlugin({'no_bools': false});
     newFile(filePath, 'bool b = false;');
     await channel
@@ -193,19 +191,19 @@ class PluginServerTest extends PluginServerTestBase {
         .map((n) => protocol.AnalysisErrorsParams.fromNotification(n))
         .where((p) => p.file == filePath));
     var params = await paramsQueue.next;
-    _expectAnalysisError(params.errors.single, message: 'No bools message');
+    expect(params.errors, isEmpty);
   }
 
   void writeAnalysisOptionsWithPlugin(
-      [Map<String, bool> ruleConfiguration = const {}]) {
+      [Map<String, bool> diagnosticConfiguration = const {}]) {
     var buffer = StringBuffer('''
 plugins:
   no_literals:
-    rules:
+    diagnostics:
 ''');
-    for (var MapEntry(key: ruleName, value: isEnabled)
-        in ruleConfiguration.entries) {
-      buffer.writeln('      $ruleName: $isEnabled');
+    for (var MapEntry(key: diagnosticName, value: isEnabled)
+        in diagnosticConfiguration.entries) {
+      buffer.writeln('      $diagnosticName: $isEnabled');
     }
     newAnalysisOptionsYamlFile(packagePath, buffer.toString());
   }

pkg/analyzer/CHANGELOG.md

@@ -34,6 +34,7 @@
 * Remove deprecated `source_resource.dart`.
 * Remove `MultiplyInheritedExecutableElement`.
 * Remove `AnalyzeFunctionBodiesPredicate`.
+* Remove `normalParameterNames` and `optionalParameterNames` from `FunctionType`.
 
 ## 6.11.0
 * Un-deprecated `LibraryElement.exportedLibraries`.