Skip to content

Commit

Permalink
Version 3.7.0-112.0.dev
Browse files Browse the repository at this point in the history
Merge 9645a71 into dev
  • Loading branch information
Dart CI committed Nov 6, 2024
2 parents ac93f82 + 9645a71 commit d456f61
Show file tree
Hide file tree
Showing 24 changed files with 440 additions and 1,045 deletions.
5 changes: 5 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@ group("most") {
":dartanalyzer",
":ddc",
":runtime",
":samples",
]
}

group("samples") {
deps = [ "samples/embedder:all" ]
}

group("runtime") {
import("runtime/runtime_args.gni")

Expand Down
140 changes: 0 additions & 140 deletions pkg/analysis_server/lib/src/domains/execution/completion.dart

This file was deleted.

14 changes: 8 additions & 6 deletions pkg/analysis_server/lib/src/legacy_analysis_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ class LegacyAnalysisServer extends AnalysisServer {
}

/// Handle a [request] that was read from the communication channel.
void handleRequest(Request request) {
void handleRequest(Request request, CancelableToken? cancellationToken) {
var startTime = DateTime.now();
performance.logRequestTiming(request.clientRequestTime);

Expand All @@ -556,12 +556,11 @@ class LegacyAnalysisServer extends AnalysisServer {
);
recentPerformance.requests.add(requestPerformance!);

var cancellationToken = CancelableToken();
cancellationTokens[request.id] = cancellationToken;
var token = cancellationToken ??= CancelableToken();
cancellationTokens[request.id] = token;
var generator = requestHandlerGenerators[request.method];
if (generator != null) {
var handler =
generator(this, request, cancellationToken, performance);
var handler = generator(this, request, token, performance);
if (!handler.recordsOwnAnalytics) {
analyticsManager.startedRequest(
request: request, startTime: startTime);
Expand Down Expand Up @@ -607,7 +606,10 @@ class LegacyAnalysisServer extends AnalysisServer {
/// Handle a [request] that was read from the communication channel.
void handleRequestOrResponse(RequestOrResponse requestOrResponse) {
if (requestOrResponse is Request) {
messageScheduler.add(LegacyMessage(request: requestOrResponse));
var cancellationToken = CancelableToken();
cancellationTokens[requestOrResponse.id] = cancellationToken;
messageScheduler.add(LegacyMessage(
request: requestOrResponse, cancellationToken: cancellationToken));
messageScheduler.notify();
} else if (requestOrResponse is Response) {
handleResponse(requestOrResponse);
Expand Down
6 changes: 4 additions & 2 deletions pkg/analysis_server/lib/src/server/message_scheduler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ final class DtdMessage extends MessageObject {
/// Represents a message in the Legacy protocol format.
final class LegacyMessage extends MessageObject {
final legacy.Request request;
CancelableToken? cancellationToken;

LegacyMessage({required this.request});
LegacyMessage({required this.request, this.cancellationToken});
}

/// Represents a message in the LSP protocol format.
Expand Down Expand Up @@ -81,7 +82,8 @@ final class MessageScheduler {
cancellationToken: message.cancellationToken);
case LegacyMessage():
var request = message.request;
(server as LegacyAnalysisServer).handleRequest(request);
(server as LegacyAnalysisServer)
.handleRequest(request, message.cancellationToken);
case DtdMessage():
server.dtd!.processMessage(
message.message, message.performance, message.completer);
Expand Down
Loading

0 comments on commit d456f61

Please sign in to comment.