Skip to content

Commit

Permalink
Version 2.19.0-360.0.dev
Browse files Browse the repository at this point in the history 
Merge d68d1ff into dev
  • Loading branch information
Dart CI committed Nov 1, 2022
2 parents b177ece + d68d1ff commit e360a69
Show file tree
Hide file tree
Showing 14 changed files with 19 additions and 558 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,13 @@ Updated the Linter to `1.28.0`, which includes changes that
- **Breaking change** [49473](https://github.com/dart-lang/sdk/issues/49473):
dart2js no longer supports HTTP URIs as inputs.

## 2.18.4 - 2022-11-02

This is a patch release that fixes crashes during hot reload
(issue [flutter/flutter#113540][]).

[flutter/flutter#113540]: https://github.com/flutter/flutter/issues/113540

## 2.18.3 - 2022-10-19

This is a patch release that fixes a regression in code coverage computation
Expand Down
4 changes: 2 additions & 2 deletions DEPS
View file
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ vars = {
"dart_style_rev": "f79a9828ad07e50d6e8352ac154cc16eb4d78d5c", # manually rev'd

"dartdoc_rev": "3273437229b89289534edd3b15934ac75921fa6b",
"devtools_rev": "b21cd59f1f6bb60cacd59ba39e376d2a50d82f74",
"devtools_rev": "23444af89d716818f099974df3e4fffac87fd886",
"ffi_rev": "fb5f2667826c0900e551d19101052f84e35f41bf",
"file_rev": "b2e31cb6ef40b223701dbfa0b907fe58468484d7",
"fixnum_rev": "e0b17cc1f639c55a9c24947392c64b5a68992535",
Expand All @@ -139,7 +139,7 @@ vars = {
"linter_rev": "f2c55484e8ebda0aec8c2fea637b3bd5b17258ca", # 1.28.0
"lints_rev": "16bdefe1df529262a6596f79e91003ddbdbd3890",
"logging_rev": "f322480fb9d9e83e677c08db6d09067059f7ff74",
"markdown_rev": "49eefd211e7840bac7e11257cd966435ae3cb07f",
"markdown_rev": "f3873403f5b1a0319f78632a8fbc2b22315a7b83", # b/256680494
"markupsafe_rev": "8f45f5cfa0009d2a70589bcda0349b8cb2b72783",
"matcher_rev": "6a9b83bbd73e50df2058b3e8e4aa301df49569c6",
"mime_rev": "bf041aa372a27aae6f94e185aa0af3932b9de98b",
Expand Down
67 changes: 1 addition & 66 deletions pkg/analyzer/lib/dart/ast/ast.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,6 @@ abstract class AstVisitor<R> {

R? visitGenericTypeAlias(GenericTypeAlias node);

R? visitHideClause(HideClause node);

R? visitHideCombinator(HideCombinator node);

R? visitIfElement(IfElement node);
Expand Down Expand Up @@ -614,12 +612,8 @@ abstract class AstVisitor<R> {

R? visitSetOrMapLiteral(SetOrMapLiteral node);

R? visitShowClause(ShowClause node);

R? visitShowCombinator(ShowCombinator node);

R? visitShowHideElement(ShowHideElement node);

R? visitSimpleFormalParameter(SimpleFormalParameter node);

R? visitSimpleIdentifier(SimpleIdentifier node);
Expand Down Expand Up @@ -2101,10 +2095,6 @@ abstract class ExtensionDeclaration implements CompilationUnitMember {
/// Return the token representing the 'extension' keyword.
Token get extensionKeyword;

/// Return the hide clause, or `null` if the extension does not have a hide
/// clause.
HideClause? get hideClause;

/// Return the left curly bracket.
Token get leftBracket;

Expand All @@ -2126,10 +2116,6 @@ abstract class ExtensionDeclaration implements CompilationUnitMember {
/// Return the right curly bracket.
Token get rightBracket;

/// Return the show clause, or `null` if the extension does not have a show
/// clause.
ShowClause? get showClause;

/// Return the token representing the 'type' keyword.
Token? get typeKeyword;

Expand Down Expand Up @@ -2916,20 +2902,6 @@ abstract class GenericTypeAlias implements TypeAlias {
TypeParameterList? get typeParameters;
}

/// The "hide" clause in an extension declaration.
///
/// hideClause ::=
/// 'hide' [TypeName] (',' [TypeName])*
///
/// Clients may not extend, implement or mix-in this class.
abstract class HideClause implements AstNode {
/// Return the list of the elements that are being shown.
NodeList<ShowHideClauseElement> get elements;

/// Return the token representing the 'hide' keyword.
Token get hideKeyword;
}

/// A combinator that restricts the names being imported to those that are not
/// in a given list.
///
Expand Down Expand Up @@ -3832,7 +3804,7 @@ abstract class NamedExpression implements Expression {
/// [Identifier] typeArguments?
///
/// Clients may not extend, implement or mix-in this class.
abstract class NamedType implements TypeAnnotation, ShowHideClauseElement {
abstract class NamedType implements TypeAnnotation {
/// Return `true` if this type is a deferred type.
///
/// 15.1 Static Types: A type <i>T</i> is deferred iff it is of the form
Expand Down Expand Up @@ -4589,20 +4561,6 @@ abstract class SetOrMapLiteral implements TypedLiteral {
Token get rightBracket;
}

/// The "show" clause in an extension declaration.
///
/// showClause ::=
/// 'show' [TypeName] (',' [TypeName])*
///
/// Clients may not extend, implement or mix-in this class.
abstract class ShowClause implements AstNode {
/// Return the list of the elements that are being shown.
NodeList<ShowHideClauseElement> get elements;

/// Return the token representing the 'show' keyword.
Token get showKeyword;
}

/// A combinator that restricts the names being imported to those in a given list.
///
/// showCombinator ::=
Expand All @@ -4615,29 +4573,6 @@ abstract class ShowCombinator implements Combinator {
NodeList<SimpleIdentifier> get shownNames;
}

/// A node that can appear in the show or hide clauses.
///
/// Clients may not extend, implement or mix-in this class.
abstract class ShowHideClauseElement implements AstNode {}

/// A potentially non-type element of a show or a hide clause.
///
/// showHideElement ::=
/// 'get' [SimpleIdentifier] |
/// 'set' [SimpleIdentifier] |
/// 'operator' [SimpleIdentifier] |
/// [SimpleIdentifier]
///
/// Clients may not extend, implement or mix-in this class.
abstract class ShowHideElement implements AstNode, ShowHideClauseElement {
/// Return the 'get', 'set', or 'operator' modifier that appears before the
/// name, or `null` if there is no modifier.
Token? get modifier;

/// Return the name of the member the element refers to.
SimpleIdentifier get name;
}

/// A simple formal parameter.
///
/// simpleFormalParameter ::=
Expand Down
78 changes: 0 additions & 78 deletions pkg/analyzer/lib/dart/ast/visitor.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,6 @@ class GeneralizingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitGenericTypeAlias(GenericTypeAlias node) => visitTypeAlias(node);

@override
R? visitHideClause(HideClause node) => visitNode(node);

@override
R? visitHideCombinator(HideCombinator node) => visitCombinator(node);

Expand Down Expand Up @@ -627,15 +624,9 @@ class GeneralizingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitSetOrMapLiteral(SetOrMapLiteral node) => visitTypedLiteral(node);

@override
R? visitShowClause(ShowClause node) => visitNode(node);

@override
R? visitShowCombinator(ShowCombinator node) => visitCombinator(node);

@override
R? visitShowHideElement(ShowHideElement node) => visitNode(node);

@override
R? visitSimpleFormalParameter(SimpleFormalParameter node) =>
visitNormalFormalParameter(node);
Expand Down Expand Up @@ -1204,12 +1195,6 @@ class RecursiveAstVisitor<R> implements AstVisitor<R> {
return null;
}

@override
R? visitHideClause(HideClause node) {
node.visitChildren(this);
return null;
}

@override
R? visitHideCombinator(HideCombinator node) {
node.visitChildren(this);
Expand Down Expand Up @@ -1562,24 +1547,12 @@ class RecursiveAstVisitor<R> implements AstVisitor<R> {
return null;
}

@override
R? visitShowClause(ShowClause node) {
node.visitChildren(this);
return null;
}

@override
R? visitShowCombinator(ShowCombinator node) {
node.visitChildren(this);
return null;
}

@override
R? visitShowHideElement(ShowHideElement node) {
node.visitChildren(this);
return null;
}

@override
R? visitSimpleFormalParameter(SimpleFormalParameter node) {
node.visitChildren(this);
Expand Down Expand Up @@ -1999,9 +1972,6 @@ class SimpleAstVisitor<R> implements AstVisitor<R> {
@override
R? visitGenericTypeAlias(GenericTypeAlias node) => null;

@override
R? visitHideClause(HideClause node) => null;

@override
R? visitHideCombinator(HideCombinator node) => null;

Expand Down Expand Up @@ -2187,15 +2157,9 @@ class SimpleAstVisitor<R> implements AstVisitor<R> {
@override
R? visitSetOrMapLiteral(SetOrMapLiteral node) => null;

@override
R? visitShowClause(ShowClause node) => null;

@override
R? visitShowCombinator(ShowCombinator node) => null;

@override
R? visitShowHideElement(ShowHideElement node) => null;

@override
R? visitSimpleFormalParameter(SimpleFormalParameter node) => null;

Expand Down Expand Up @@ -2526,9 +2490,6 @@ class ThrowingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitGenericTypeAlias(GenericTypeAlias node) => _throw(node);

@override
R? visitHideClause(HideClause node) => _throw(node);

@override
R? visitHideCombinator(HideCombinator node) => _throw(node);

Expand Down Expand Up @@ -2717,15 +2678,9 @@ class ThrowingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitSetOrMapLiteral(SetOrMapLiteral node) => _throw(node);

@override
R? visitShowClause(ShowClause node) => _throw(node);

@override
R? visitShowCombinator(ShowCombinator node) => _throw(node);

@override
R? visitShowHideElement(ShowHideElement node) => _throw(node);

@override
R? visitSimpleFormalParameter(SimpleFormalParameter node) => _throw(node);

Expand Down Expand Up @@ -3413,14 +3368,6 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
return result;
}

@override
T? visitHideClause(HideClause node) {
stopwatch.start();
T? result = _baseVisitor.visitHideClause(node);
stopwatch.stop();
return result;
}

@override
T? visitHideCombinator(HideCombinator node) {
stopwatch.start();
Expand Down Expand Up @@ -3889,14 +3836,6 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
return result;
}

@override
T? visitShowClause(ShowClause node) {
stopwatch.start();
T? result = _baseVisitor.visitShowClause(node);
stopwatch.stop();
return result;
}

@override
T? visitShowCombinator(ShowCombinator node) {
stopwatch.start();
Expand All @@ -3905,14 +3844,6 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
return result;
}

@override
T? visitShowHideElement(ShowHideElement node) {
stopwatch.start();
T? result = _baseVisitor.visitShowHideElement(node);
stopwatch.stop();
return result;
}

@override
T? visitSimpleFormalParameter(SimpleFormalParameter node) {
stopwatch.start();
Expand Down Expand Up @@ -4412,9 +4343,6 @@ class UnifyingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitGenericTypeAlias(GenericTypeAlias node) => visitNode(node);

@override
R? visitHideClause(HideClause node) => visitNode(node);

@override
R? visitHideCombinator(HideCombinator node) => visitNode(node);

Expand Down Expand Up @@ -4611,15 +4539,9 @@ class UnifyingAstVisitor<R> implements AstVisitor<R> {
@override
R? visitSetOrMapLiteral(SetOrMapLiteral node) => visitNode(node);

@override
R? visitShowClause(ShowClause node) => visitNode(node);

@override
R? visitShowCombinator(ShowCombinator node) => visitNode(node);

@override
R? visitShowHideElement(ShowHideElement node) => visitNode(node);

@override
R? visitSimpleFormalParameter(SimpleFormalParameter node) => visitNode(node);

Expand Down
Loading

0 comments on commit e360a69

Please sign in to comment.