-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class Promise is poorly documented. #232
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-not-planned
Closed as we don't intend to take action on the reported issue
Comments
This comment was originally written by [email protected] Added Area-Library, Triaged labels. |
This comment was originally written by [email protected] Additional question: |
Promise was removed, use Future now. Added WontFix label. |
DartBot
added
Type-Defect
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
labels
May 6, 2012
kevmoo
added
closed-not-planned
Closed as we don't intend to take action on the reported issue
and removed
resolution-wont_fix
labels
Mar 1, 2016
nex3
pushed a commit
that referenced
this issue
Aug 31, 2016
our renamer wasn't trusting the JS builtin to use arguments correctly :) incidentally, this does the final step in making the renamer precise: it tracks all renames per-scope now. In practice this was almost never hit except for "arguments" though. [email protected] Review URL: https://codereview.chromium.org/1200243002.
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
Oct 31, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/4902bea..3273437): 32734372 2022-10-30 Sam Rawlins Move Warnable.enclosingElement to ModelElement (#3236) 1ff17d8e 2022-10-28 Sam Rawlins Make ContainerMember.canonicalEnclosingContainer late final (#3234) c32e09ee 2022-10-28 Sam Rawlins Support displaying record types (#3233) 9d194476 2022-10-26 Sam Rawlins Update the text in test/README (#3232) mockito (https://github.com/dart-lang/mockito/compare/02ad6c7..094d07c): 094d07c 2022-10-25 Sam Rawlins Require analyzer 5.2.0 test (https://github.com/dart-lang/test/compare/f704d5a..b82fc0b): b82fc0b5 2022-10-27 Jacob MacDonald Experimental wasm support (#1777) 262bc7bd 2022-10-26 Nate Bosch Bump to the latest matcher and prepare to publish (#1778) fa81b45d 2022-10-26 Nate Bosch Expand test_api pubspec description (#1775) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/4b46c0c..eba1541): eba1541 2022-10-27 Siva Remove language version from spawnHybrid code (#232) webdriver (https://github.com/google/webdriver.dart/compare/f56cc6a..c28cf51): c28cf51 2022-10-26 Devon Carew misc updates and rev in prep for publishing (#256) Change-Id: I3876e957ffa21333ced4ad3f6df4ef35103674a2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266720 Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Devon Carew <[email protected]> Commit-Queue: Kevin Moore <[email protected]> Auto-Submit: Devon Carew <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Jan 26, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/04c9346..a23ea85): a23ea85 2023-01-25 Devon Carew update the publishing script (#232) dartdoc (https://github.com/dart-lang/dartdoc/compare/ed56883..99df16a): 99df16a0 2023-01-24 Parker Lougheed Use a sun for light theme toggle instead of moon (#3309) 758e1851 2023-01-24 Parker Lougheed Switch dart:js and some dart:js_util usages to use static interop (#3299) 9735d895 2023-01-24 dependabot[bot] Bump github/codeql-action from 2.1.38 to 2.1.39 (#3306) f6cd8eb9 2023-01-23 Sam Rawlins Fix various bits in testing code to comply with new warnings (#3307) http (https://github.com/dart-lang/http/compare/57c53b0..092bb2d): 092bb2d 2023-01-25 Brian Quinlan Create a `package:cronet_http/cronet_http.dart` import (#859) a62f5b3 2023-01-24 Brian Quinlan Create a single top-level lib file. (#858) intl (https://github.com/dart-lang/intl/compare/3fcc810..946c34c): 946c34c 2023-01-25 Copybara-Service Merge pull request #533 from dart-lang:updateVersion 19b6785 2023-01-20 Moritz Append `-dev` to current version sse (https://github.com/dart-lang/sse/compare/be426a2..4e63b08): 4e63b08 2023-01-25 Kevin Moore Fix deprecated import to webdriver library (#76) webdev (https://github.com/dart-lang/webdev/compare/f978b90..a347fa0): a347fa0 2023-01-25 Anna Gringauze Update vm_service to version 10.0.0 (#1917) 4dd29a5 2023-01-24 Anna Gringauze Allow dart SDK <4.0.0 (#1913) b3db2c9 2023-01-24 Anna Gringauze Prepare for dart 3.0 alpha changes: Handle SDK layout update (#1907) Change-Id: I84d827db044f5b0af49b0454fd1d69b0d2ddf692 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279901 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Nov 1, 2023
…, convert, crypto, csslib, ecosystem, ffi, file, fixnum, html, http, lints, logging, markdown, matcher, mime, native, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, test_process, test_reflective_loader, tools, typed_data, watcher, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/def4482..9924570): 9924570 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#255) 61cdb0f 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#254) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/479e1c1..7f523c3): 7f523c3 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#53) 1ed2941 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#54) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/c2871b2..4f9e784): 4f9e784 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51) 706c031 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#52) cli_util (https://github.com/dart-lang/cli_util/compare/56c1235..500dffa): 500dffa 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#91) c66e201 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#92) clock (https://github.com/dart-lang/clock/compare/200a020..f975668): f975668 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#59) eb5d2f5 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#58) convert (https://github.com/dart-lang/convert/compare/03242b2..f24afa7): f24afa7 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#89) a3e9bc5 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#90) crypto (https://github.com/dart-lang/crypto/compare/36ead7c..f3e64d2): f3e64d2 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#155) 7a7b517 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#156) csslib (https://github.com/dart-lang/csslib/compare/f6b68dd..17346e5): 17346e5 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191) 4bdc553 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#192) ecosystem (https://github.com/dart-lang/ecosystem/compare/4acfcaf..dda7886): dda7886 2023-11-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#192) b681c56 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#193) 0d768d4 2023-11-01 dependabot[bot] Bump subosito/flutter-action from 2.10.0 to 2.12.0 (#190) 178d244 2023-11-01 dependabot[bot] Bump actions/github-script (#194) 4b3e572 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191) ffi (https://github.com/dart-lang/ffi/compare/2faec28..c926657): c926657 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#219) 3181ec0 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#220) file (https://github.com/google/file.dart/compare/7418131..e7c03aa): e7c03aa 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#233) fixnum (https://github.com/dart-lang/fixnum/compare/ef45eb5..3279f5d): 3279f5d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#120) 4913894 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#121) html (https://github.com/dart-lang/html/compare/49e2c8e..06bc148): 06bc148 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#232) 2630607 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#233) http (https://github.com/dart-lang/http/compare/7240d0a..b9389fe): b9389fe 2023-11-01 dependabot[bot] Bump futureware-tech/simulator-action from 2 to 3 (#1037) d7c36ae 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#1038) lints (https://github.com/dart-lang/lints/compare/5c60f48..f58fd77): f58fd77 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#168) logging (https://github.com/dart-lang/logging/compare/642ed21..324a0b5): 324a0b5 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#150) e9b13b7 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#151) markdown (https://github.com/dart-lang/markdown/compare/4e2e970..efb73b3): efb73b3 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#561) 2e4a3bc 2023-11-01 dependabot[bot] Bump subosito/flutter-action from 2.10.0 to 2.11.0 (#559) 22e378b 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#560) matcher (https://github.com/dart-lang/matcher/compare/7512f80..3d03fa1): 3d03fa1 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#231) b7d24c8 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#232) mime (https://github.com/dart-lang/mime/compare/af3e5fe..8ebf946): 8ebf946 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#108) 4328d32 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#107) native (https://github.com/dart-lang/native/compare/279094d..de9d59e): de9d59e 2023-11-01 Daco Harkes [infra] Fix PR publisher comments (#177) 22b6b24 2023-11-01 Daco Harkes [infra] Rename `dart.yaml` to `native.yaml` (#176) cc42fb1 2023-11-01 Daco Harkes [native_toolchain_c] Use sysroot on Android (#180) 01d92b0 2023-11-01 Daco Harkes [native_toolchain_c] Bump highest tested NDK version to 34 (#182) 53facde 2023-11-01 Daco Harkes [native_toolchain_c] Fix NDK discovery (#179) 285ee6c 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#174) 46a05e4 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#172) 23187fe 2023-11-01 dependabot[bot] Bump nttld/setup-ndk from 1.3.1 to 1.4.1 (#173) path (https://github.com/dart-lang/path/compare/4ca27d4..18ec71f): 18ec71f 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#153) f26c20c 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#154) pool (https://github.com/dart-lang/pool/compare/5ccef15..c78cef4): c78cef4 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76) protobuf (https://github.com/dart-lang/protobuf/compare/3f567b2..dcec2ed): dcec2ed 2023-10-31 Ömer Sinan Ağacan Annotate deepCopy with @useResult (#897) pub_semver (https://github.com/dart-lang/pub_semver/compare/8e5a58f..f9e94ee): f9e94ee 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#95) 81fdbcf 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#94) shelf (https://github.com/dart-lang/shelf/compare/c15fc6f..b3adc7c): b3adc7c 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#391) baea52d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#392) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/73d449c..2209626): 2209626 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#45) bfa3949 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#44) source_maps (https://github.com/dart-lang/source_maps/compare/fc6aa16..87dc587): 87dc587 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#84) 33ba11d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#85) source_span (https://github.com/dart-lang/source_span/compare/92e50bf..ed16e0d): ed16e0d 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#105) aacd748 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#104) sse (https://github.com/dart-lang/sse/compare/37df57d..8ddb95f): 8ddb95f 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#95) 8830125 2023-11-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#94) 86dd8f9 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#93) stack_trace (https://github.com/dart-lang/stack_trace/compare/634589f..6496ff8): 6496ff8 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#145) 3d60304 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#144) stream_channel (https://github.com/dart-lang/stream_channel/compare/ffdb208..178104d): 178104d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#98) 1193387 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#97) string_scanner (https://github.com/dart-lang/string_scanner/compare/9c525f7..a7105ef): a7105ef 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#65) f33ca6f 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#66) term_glyph (https://github.com/dart-lang/term_glyph/compare/cff80de..7c1eb9d): 7c1eb9d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#45) 39073ca 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#44) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/55b5eac..c417cbb): c417cbb 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#59) dcfde39 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#58) test_process (https://github.com/dart-lang/test_process/compare/d610333..c21e40d): c21e40d 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51) bfd0576 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#50) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/8593eb1..17d40bb): 17d40bb 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#54) e664092 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#55) tools (https://github.com/dart-lang/tools/compare/01c0b52..dd91cb6): dd91cb6 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#192) 603b012 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191) typed_data (https://github.com/dart-lang/typed_data/compare/d1c15ed..0b16bd2): 0b16bd2 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76) f869102 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#77) watcher (https://github.com/dart-lang/watcher/compare/6ad58dc..b2b278a): b2b278a 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154) 97e9637 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#155) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/f3ac1bf..82ac73f): 82ac73f 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289) 3615850 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#290) webdriver (https://github.com/google/webdriver.dart/compare/eaf9c58..43ed1db): 43ed1db 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289) 02fd658 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#288) 8828360 2023-11-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#287) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/82f0c1c..2c6f8b6): 2c6f8b6 2023-11-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.1 (#114) d4e4d55 2023-11-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#115) yaml (https://github.com/dart-lang/yaml/compare/9f0d649..98a3aab): 98a3aab 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154) b63372b 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#155) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/a7e7fba..9b9d33c): 9b9d33c 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#61) b71c2e8 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#60) Change-Id: I8b663f536d4e80728c6570372d886edfef227cf1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333059 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Nov 2, 2023
…lob, http_multi_server, http_parser, json_rpc_2, mockito, native, package_config, pool, sync_http, usage, webkit_inspection_protocol Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/df9b428..46d5033): 46d5033 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#258) 5f7c8b5 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#259) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/b1b6a66..3d9cd58): 3d9cd58 2023-11-02 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#83) 1d7bed3 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#84) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/59aea95..e59f675): e59f675 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#96) 1899e39 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#95) collection (https://github.com/dart-lang/collection/compare/d27bfaf..e8d7e92): e8d7e92 2023-11-02 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#318) 1f5c234 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#319) file (https://github.com/google/file.dart/compare/e7c03aa..cd3a932): cd3a932 2023-11-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.1 (#232) glob (https://github.com/dart-lang/glob/compare/0046533..7c9a121): 7c9a121 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#86) 713142b 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#85) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/03041aa..2238a6b): 2238a6b 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#60) http_parser (https://github.com/dart-lang/http_parser/compare/c557f57..1cf5b7c): 1cf5b7c 2023-11-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#80) cb6f142 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#81) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/0521afb..460545c): 460545c 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#105) 189b1a8 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#106) mockito (https://github.com/dart-lang/mockito/compare/b7d752e..fcb9779): fcb9779 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#713) 1c4a6ff 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#712) native (https://github.com/dart-lang/native/compare/de9d59e..c72ed16): c72ed16 2023-11-01 Daco Harkes [native_toolchain_c] Bump version to 0.3.2 (#184) 4c9a50f 2023-11-01 Daco Harkes [native_toolchain_c] Add workaround for minSdkVersion 19 and 20 (#181) 45b5e6c 2023-11-01 Daco Harkes [infra] Bump NDK version (#183) package_config (https://github.com/dart-lang/package_config/compare/100533d..33dd246): 33dd246 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#144) 30c8f25 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#143) pool (https://github.com/dart-lang/pool/compare/c78cef4..3c1bd42): 3c1bd42 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#77) sync_http (https://github.com/dart-lang/sync_http/compare/8233f74..d8e9f3d): d8e9f3d 2023-11-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.1 (#40) c59b6d4 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#41) usage (https://github.com/dart-lang/usage/compare/d7d2964..e99690a): e99690a 2023-11-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#201) a540a6d 2023-11-01 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#200) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/2c6f8b6..667c55e): 667c55e 2023-11-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#113) Change-Id: Ie6f2f0df0060cd77b9d56dc40172c134605417e7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333680 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-not-planned
Closed as we don't intend to take action on the reported issue
This issue was originally filed by [email protected]
A Promise can be accomplished in 3 ways: complete, fail, and cancelled. It is not always clear from the documentation, what happens if an attempt is made to accomplish a promise which is already done (e.g.p. promise.fail() for completed promise), and what happens when attempting to take the result of unexistent kind (e.g. Promise.value for failed promise).
More detailed list of questions is as follows:
"throws an exception if a value has already been provided or the promise
previously completed with an error"
However, the type of exception is not specified.
"Every time one of the promises is computed, it is passed to joinDone."
Nothing is said what happens when the promise has failed or has been cancelled.
"when n promises in arr complete, then cancel the rest of the promises"
Nothing is said what happens when one of the said n promises has failed or has been cancelled.
"It will be null when the promise is in progress (!isDone()), when it was
cancelled (isCancelled()), or when the computed value is actually null."
Nothing is said what happens when the promise has failed.
Is it legal to call fail() on cancelled promise? Current implementation allows this, which leads to the situation when isCancelled()==true but call to 'value' throws an exception, while it should return 'null' according to the description of Promise.value.
The text was updated successfully, but these errors were encountered: