Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please merge async crash fix to stable #26681

Closed
whesse opened this issue Jun 10, 2016 · 2 comments
Closed

Please merge async crash fix to stable #26681

whesse opened this issue Jun 10, 2016 · 2 comments
Assignees
@whesse
Labels
merge-to-stable

Comments

@whesse
Copy link
Contributor

whesse commented Jun 10, 2016

Please merge
f4029bf
and
e803457
to 1.17 stable.

This fixes a case where an async function can crash.
#26668 #26678 @crelier @kevmoo
@whesse whesse self-assigned this Jun 10, 2016
@whesse
Copy link
Contributor Author

whesse commented Jun 10, 2016

Please compare the commit to stable with your commit to bleeding edge - there was a merge conflict, and a build failure, and I had to resolve it. And test the stable build, from http://gsdview.appspot.com/dart-archive/channels/stable/raw/1.17.1/
to verify that the bug is fixed.

@whesse
Copy link
Contributor Author

whesse commented Jun 10, 2016

Verified that this is fixed in 1.17.1 - the reproduction test passes.

Merged in version 1.17.1

@whesse whesse closed this as completed Jun 10, 2016
pq added a commit to pq/flutter that referenced this issue Jun 10, 2016
@pq
Bump Dart SDK to patched stable.
c1f10db 
`1.17.1` fixes:
* crash in async functions
* GC bug in weak properties

Relevant patches here:
* dart-lang/sdk#26680
* dart-lang/sdk#26681
@pq pq mentioned this issue Jun 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whesse