Web sockets onClose should return 0 and empty string

[sethladd]

From the mailing list:

I am playing around with this today, and it works for me. However,
when I disconnect from the client (i'm using http://websocket.org/echo.html
for now) I am getting null for the status/reason in the onClosed
callback?

conn.onClosed = (int status, String reason) {
     print("closed with $status for $reason");
   };

--> closed with null for null

hmm, looking at the dart API docs for WebSocketConnection.close and
WebSocketClientConnection.close this seems it may be intentional:

Close the web socket connection. The default value for status and
reason are null.

However, in the spec (http://dev.w3.org/html5/websockets/) I read (see
CloseEvent) that these should default to zero and empty string,
respectively :

---

The code attribute must return the value it was initialized to. When
the object is created, this attribute must be initialized to zero. It
represents the WebSocket connection close code provided by the server.

The reason attribute must return the value it was initialized to. When
the object is created, this attribute must be initialized to empty
string. It represents the WebSocket connection close reason provided
by the server.

---

[sgjesse]

Added this to the M1 milestone.

[andersjohnsen]

Set owner to @Skabet.
Added Accepted label.

[andersjohnsen]

We have implemented the WebSocket using http://tools.ietf.org/html/rfc6455#section-7.1.5, where it have a slightly different wording. Nonetheless, I've implemented so that:

* We always call onClosed (even when the connection is unexpected closed).

• Give default 1005 in case of correct close with default empty string as reason.
• Give 1006 in case of bad close with an appropriate message (e.g. 'Unexpected close' or the actual socket/http-connection error message).

Let me know if you have any further request in this regard.

• Anders

  ---

  Added Fixed label.

[kevmoo]

Removed Area-IO label.
Added Area-Library, Library-IO labels.