Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't access href of SVGImageElement #3034

Closed
DartBot opened this issue May 13, 2012 · 9 comments
Closed

Can't access href of SVGImageElement #3034

DartBot opened this issue May 13, 2012 · 9 comments
Assignees
@blois
Labels
closed-duplicate Closed in favor of an existing report web-libraries Issues impacting dart:html, etc., libraries
Milestone
M2

Comments

@DartBot
Copy link

DartBot commented May 13, 2012

This issue was originally filed by [email protected]

Latest Dartium complains with:

'SVGURIReference' is not loaded

when accessed directly (using is operator), and when trying to access href field of SVGImageElement, I get:

Exception: NoSuchMethodException : method not found: 'get:href'
Receiver: Instance of '_SVGImageElementImpl@33cc944a'

Then with frogc, I don't even get here, because the Document from XHR response, doesn't seem to have query method:

Uncaught NoSuchMethodException : method not found: 'query'
Receiver: [object Document]
Arguments: [#body]

Looking at the compiled JS, I don't see where XHR's response would be wrapped in dart's Document. When I try to do querySelector instead, then that gets compiled into noSuchMethod.
@DartBot
Copy link
Author

DartBot commented May 14, 2012

This comment was originally written by [email protected]

cc @rakudrama.
cc @vsmenon.
Added Area-DOM, Triaged labels.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 14, 2012

dusan.maliarik, can you please include a test if this is still an issue? It's not clear what you mean by "Document from XHR response".

thanks!

Added this to the Later milestone.
Added NeedsInfo label.

@DartBot
Copy link
Author

DartBot commented Aug 14, 2012

This comment was originally written by [email protected]

@vsm That's a Document object obtained via http://api.dartlang.org/docs/continuous/dart_html/XMLHttpRequest.html#response

@DartBot
Copy link
Author

DartBot commented Aug 14, 2012

This comment was originally written by [email protected]

To clarify, these are probably 2 issues. One is SVGImageElement and its href attribute, the other one is Document coming from XHR.

@vsmenon
Copy link
Member

vsmenon commented Aug 14, 2012

Thanks, do you still have your code for this?

@DartBot
Copy link
Author

DartBot commented Aug 15, 2012

This comment was originally written by [email protected]

I have this one for XHR https://gist.github.com/3351977

@blois
Copy link
Contributor

blois commented Oct 15, 2012

Removed this from the Later milestone.
Added this to the M2 milestone.

@blois
Copy link
Contributor

blois commented Nov 20, 2012

There were some issues with using the Document from an XMLHttpRequest, see issues #­6453 and #­3420.

In addition, there is bug #­5395 with issues around SVG's href, that is in progress right now.

Set owner to @blois.
Added Duplicate label.
Marked as being merged into #3420.

@DartBot DartBot added Type-Defect web-libraries Issues impacting dart:html, etc., libraries closed-duplicate Closed in favor of an existing report labels Nov 20, 2012
@DartBot DartBot added this to the M2 milestone Nov 20, 2012
@blois blois mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue May 20, 2022
Roll Dart Documentation Generator from 334072b0cad4 to cf0685a2d1ce (…
fa6abd3 
…25 revisions)

https://dart.googlesource.com/dartdoc/+log/334072b0cad4..cf0685a2d1ce

2022-05-19 [email protected] Create scorecards-analysis.yml (#3032)
2022-05-18 [email protected] Add the docs.dart.js.map file to published package (#3042)
2022-05-17 [email protected] Reintroduce query param search (#3026)
2022-05-17 [email protected] Include docs.dart.js in published code (#3040)
2022-05-17 [email protected] Optimize built js (#3028)
2022-05-17 [email protected] Use dart run instead of deprecated dart pub run (#3038)
2022-05-17 [email protected] fix exception for empty dartdoc_options.yaml file (#3034)
2022-05-16 [email protected] Fix build config (#3035)
2022-05-02 [email protected] Drop version back to 5.1.0 (#3031)
2022-05-02 [email protected] Fixed: YouTube directive respects width/height argument (#3030)
2022-04-19 [email protected] Update pubspec.yaml (#3025)
2022-04-12 [email protected] Remove dead field commentRefs, which is always empty (#3021)
2022-04-12 [email protected] make the converted web frontend follow Dart conventions (#3020)
2022-04-11 [email protected] convert lib/resources/script.js to Dart (#3016)
2022-04-11 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.1 to 3.0.2 (#3019)
2022-04-10 [email protected] rename the CI script (#3017)
2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 2 to 3.0.1 (#3014)
2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump markdown from 4.0.1 to 5.0.0 (#3015)
2022-04-08 [email protected] Move many static declarations to top-level; avoid RegExp (#3009)
2022-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 2 to 3 (#3013)
2022-04-07 [email protected] Add a web frontend (#3011)
2022-04-07 [email protected] enable dependabot deps checks (#3012)
2022-04-07 [email protected] Do not store the AstNode on ModelNode; eagerly grab the source indexes (#3008)
2022-04-07 [email protected] Create a .pubignore in order to skip testing files from publish check (#3010)
2022-03-29 [email protected] Bump to version 5.1.0 (#3006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I3467a27d6947c43f7f41acbb2959d72863fd8a34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245483
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blois blois

Labels
closed-duplicate Closed in favor of an existing report web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M2
Development

No branches or pull requests
4 participants
@vsmenon @blois @iposva-google @DartBot