-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify dart:html.{Point,SVGPoint} #3053
Comments
They are not equivalent.
We could make these other methods work, but only by wrapping them in code that copies the point to the correct type. We probably want to avoid all the checking and copying that would entail. Removed Type-Defect label. |
At least it'd be nice to have a Point interface and default implementation outside of dart:html that both html:Point and html:SVGPoint implement. For the simple geometric and math classes like Point, Vector2,3, etc. If there isn't a core definition there will be a multitude of incompatible implementations in libraries. |
Added Triaged label. |
Added this to the M1 milestone. |
Additionally, Point cannot be constructed on non-Webkit browsers (native type is WebKitPoint). |
Added html-api label. |
Removed Area-HTML label. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
…5 revisions) https://dart.googlesource.com/dartdoc/+log/8549817bb1b5..f5bcc4bd46f4 2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.2 to 3.0.3 (#3058) 2022-06-02 [email protected] Issue #3052: up/down arrox bug fix (#3054) 2022-06-01 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.0.4 to 1.1.0 (#3053) 2022-05-25 [email protected] Require Dart 2.17, enable and fix latest lints (#3051) 2022-05-25 [email protected] Update styles.css (#3046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I6c49e95569b83b08c53158079febaeb8a9ab2f64 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247301 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Devon Carew <[email protected]>
This issue was originally filed by @seaneagan
dart:html has two separate interfaces to represent a point:
Point
SVGPoint
These ought to be unified. See also issue #3035.
The text was updated successfully, but these errors were encountered: