Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify dart:html.{Point,SVGPoint} #3053

Closed
DartBot opened this issue May 14, 2012 · 14 comments
Closed

unify dart:html.{Point,SVGPoint} #3053

DartBot opened this issue May 14, 2012 · 14 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented May 14, 2012

This issue was originally filed by @seaneagan


dart:html has two separate interfaces to represent a point:

Point
SVGPoint

These ought to be unified. See also issue #3035.

@rakudrama
Copy link
Member

They are not equivalent.

  • SVGPoint has an additional method.
  • Methods on other interfaces that take Point or SVGPoint do not function correctly if passed the other kind of point.

We could make these other methods work, but only by wrapping them in code that copies the point to the correct type. We probably want to avoid all the checking and copying that would entail.


Removed Type-Defect label.
Added Type-Enhancement, Area-DOM labels.

@justinfagnani
Copy link
Contributor

At least it'd be nice to have a Point interface and default implementation outside of dart:html that both html:Point and html:SVGPoint implement.

For the simple geometric and math classes like Point, Vector2,3, etc. If there isn't a core definition there will be a multitude of incompatible implementations in libraries.

@sethladd
Copy link
Contributor

Added Triaged label.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 14, 2012

Added this to the M1 milestone.

@blois
Copy link
Contributor

blois commented Aug 24, 2012

Additionally, Point cannot be constructed on non-Webkit browsers (native type is WebKitPoint).

@vsmenon
Copy link
Member

vsmenon commented Sep 6, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@blois
Copy link
Contributor

blois commented Oct 15, 2012

Removed this from the M2 milestone.
Added this to the Later milestone.

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2013

Added html-api label.

@blois
Copy link
Contributor

blois commented Oct 3, 2013

Set owner to @efortuna.
Removed this from the Later milestone.
Added this to the M8 milestone.
Removed html-api label.

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2013

I have a partial CL implemented for this, but it does not modify the current api for Point. Tabling for now.


Removed this from the M8 milestone.
Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@efortuna efortuna removed their assignment Nov 16, 2017
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
copybara-service bot pushed a commit that referenced this issue Jun 6, 2022
…5 revisions)

https://dart.googlesource.com/dartdoc/+log/8549817bb1b5..f5bcc4bd46f4

2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.2 to 3.0.3 (#3058)
2022-06-02 [email protected] Issue #3052: up/down arrox bug fix (#3054)
2022-06-01 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.0.4 to 1.1.0 (#3053)
2022-05-25 [email protected] Require Dart 2.17, enable and fix latest lints (#3051)
2022-05-25 [email protected] Update styles.css (#3046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I6c49e95569b83b08c53158079febaeb8a9ab2f64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247301
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests