Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning underline not disappearing #3587

Closed
sethladd opened this issue Jun 12, 2012 · 5 comments
Closed

Warning underline not disappearing #3587

sethladd opened this issue Jun 12, 2012 · 5 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@sethladd
Copy link
Contributor

Using editor Version 0.1.0.201206061627, Build 8370

After changing some code that had a warning to code that has no warnings, a warning remains and does not disappear.

This code:

class UsernameInput extends View {
  InputElement elem;
  UsernameInput(Element parent) : super(parent);
  
  create() {
    var div = new DivElement();
    div.nodes.add(new Text("Username"));
    Element elem2 = new InputElement();
    elem2.id = 'chat-username';
    elem2.type = 'text'; // warning here, which is correct
    div.elements.add(elem2);
    parent.elements.add(div);
  }
}

When changed to:

class UsernameInput extends View {
  InputElement elem;
  UsernameInput(Element parent) : super(parent);
  
  create() {
    var div = new DivElement();
    div.nodes.add(new Text("Username"));
    elem = new InputElement();
    elem.id = 'chat-username';
    elem.type = 'text'; // there's still a warning here
    div.elements.add(elem);
    parent.elements.add(div);
  }
}

Still has the warning.

Closing and opening the file makes the warning disappear.

See attached screenshots.


Attachments:
before.png (66.48 KB)
after.png (63.68 KB)

@sethladd
Copy link
Contributor Author

cc @jwren.

@jwren
Copy link
Member

jwren commented Jun 12, 2012

Added this to the Later milestone.

@jwren
Copy link
Member

jwren commented Jun 12, 2012

Removed this from the Later milestone.
Added this to the M1 milestone.

@danrubel
Copy link

Set owner to @danrubel.

@danrubel
Copy link

Added Fixed label.

@sethladd sethladd added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 17, 2012
@sethladd sethladd added this to the M1 milestone Aug 17, 2012
copybara-service bot pushed a commit that referenced this issue Oct 18, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 28a2503..817e61d
 https://dart.googlesource.com/pub.git/+/817e61d9 Fix publishing (#3610)
 https://dart.googlesource.com/pub.git/+/97f638d0 PubToplevel.directory is never null. (#3587)
 https://dart.googlesource.com/pub.git/+/a3ee2099 Make binstubs offset invariant (#3586)
 https://dart.googlesource.com/pub.git/+/67e44b4b Make >=2.12 <3.0.0 compatible with dart 3 (#3572)
 https://dart.googlesource.com/pub.git/+/c287c110 Warn on `pub publish` if `dart analyze` has messages (#3568)
 https://dart.googlesource.com/pub.git/+/29d7d868 Cleaner pubspec.lock parsing (#3487)

```

Diff: https://dart.googlesource.com/pub.git/+/28a2503d7f4806e6854e3ed0d783f065abfd1b5f~..817e61d9eb174f77dfd2cb1d1de45826f66ac6bf/
Change-Id: I203963479a2bb78db80d8e645066a227febeef46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264680
Commit-Queue: Sigurd Meldgaard <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants