[CP] [cfe] Allow void typed switch expression #52234
Assignees
Labels
area-front-end
Use area-front-end for front end / CFE / kernel format related issues.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-merged
Cherry-pick has been merged to the stable or beta branch.
cherry-pick-review
Issue that need cherry pick triage to approve
merge-to-stable
Comments
leafpetersen
added
the
cherry-pick-review
|
As with the analyzer side of this, we will hold this for the first patch release. |
mraleph
added
the
area-front-end
|
@leafpetersen could you rebase this against the stable branch? Once the tests come back clean, we can approve this along with the analyzer cherry-pick. |
|
New Cl is linked above, and sent out for review. |
|
This CL is ready to go, let me know when I can submit. |
itsjustkevin
added
cherry-pick-approved
|
Approved, we are good to submit! |
copybara-service bot
pushed a commit
that referenced
this issue
May 15, 2023
Fixes #52234 Bug:#52191 Change-Id: I74d749115ec8cab0a89416ca905aa9c4e0d83ccc Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/299020 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303020 Commit-Queue: Leaf Petersen <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
itsjustkevin
added
the
cherry-pick-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
88721ba
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/303020
Issue Description
CFE companion to #52218. Fixes the CFE to not reject switch expressions with void arms in void contexts.
What is the fix
Allows void.
Why cherry-pick
Deviation from the specified behavior, user reported issue in beta testing.
Risk
low
Issue link(s)
#52191
Extra Info
This and the accompanying analyzer cherry pick are planned for the first hotfix release.
The text was updated successfully, but these errors were encountered: