Inline method sometimes fails with string interpolation

[bwilkerson]

Inline method doesn't work well when a parameter is referenced in a string interpolation. For example, given

List<String> f() {
  return [
    g('x'),
    g(3.toString()),
  ];
}
String g(String s) {
  return 'f($s)';
}

Iinlining both invocations of the method g produces

List<String> f() {
  return [
    'f($'x')',
    'f($3.toString())',
  ];
}
String g(String s) {
    return 'f($s)';
}

The interpolation of the parameter needs to be enclosed in a braces unless the replacement is a simple identifier.

[bwilkerson]

@scheglov

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/302641