Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Cherry-pick linter w/ improved type_literal_in_constant_pattern #52516

Closed
pq opened this issue May 25, 2023 · 1 comment
Closed

[CP] Cherry-pick linter w/ improved type_literal_in_constant_pattern #52516

pq opened this issue May 25, 2023 · 1 comment
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@pq
Copy link
Member

pq commented May 25, 2023 •
edited
Loading

Commit(s) to merge

[No existing SDK commit; this is an update to DEPS to pull in a cherry-pick on the linter in STABLE]

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/305823

Issue Description

type_literal_in_constant_pattern has been improved to add more reporting.

From @mit-mit:

We discussed this in the language team, and we think that it's high value enough to pursue as a cherry pick. We'll let you folks decide if the best approach is a linter roll or just patching this single change in.

dart-lang/linter#4358

This cherry-pick is conservative and just pulls in this one change.

See branch: https://github.com/dart-lang/linter/commits/sdk-3.0

What is the fix

Updating to lint on all type literals.

Why cherry-pick

From @mit-mit:

@johnpryan tells me that this issue seems to be mentioned as a common footgun on socials.

Risk

low

Issue link(s)

#59087

Extra Info

The commits-to-merge hash above is on the linter. This change just pulls in an update to DEPS.
@pq pq added the cherry-pick-review Issue that need cherry pick triage to approve label May 25, 2023
@pq pq mentioned this issue May 25, 2023
Closed
@mit-mit
Copy link
Member

mit-mit commented May 25, 2023

I think we should take this; we believe this is a big source of user confusion

@itsjustkevin itsjustkevin added merge-to-stable cherry-pick-approved Label for approved cherrypick request labels May 26, 2023
copybara-service bot pushed a commit that referenced this issue May 30, 2023
@pq
[stable] Cherry-pick linter w/ improved `type_literal_in_constant_pat…
47572eb 
…tern`

Linter branch: https://github.com/dart-lang/linter/commits/sdk-3.0

Motivating discussion: https://github.com/dart-lang/linter/issues/4195

Fixes: #52516

Change-Id: I9ae8ff9765b6c977eab8a3c0f190d03a9c0f2710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305823
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@itsjustkevin itsjustkevin added the cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pq @vsmenon @whesse @itsjustkevin @mit-mit @athomas