Element.html gives an error

[DartBot]

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

import('dart:html');

main() {
  String a = "foo";
  DivElement myDiv = new Element.html("<div>" + a + "</div>");
}

What is the expected output? What do you see instead?

I expect a div with the appropriate text node attached. Instead I get:

/home/jeffbailey/Programming/gclienttree/dart/dart/client/html/release/html.dart:23638:10: warning: can not resolve "innerHTML" on "Element"
    temp.innerHTML = html;
         ^^^^^^^^^
/home/jeffbailey/Programming/gclienttree/dart/dart/client/html/release/html.dart:23646:40: warning: can not resolve "children" on "Element"
      return LevelDom.wrapElement(temp.children.item(tag == 'head' ? 0 : 1));
                                       ^^^^^^^^

node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
ReferenceError: window is not defined
    at get$document (evalmachine.<anonymous>:616:10)
    at Function.ElementWrappingImplementation$html$factory (evalmachine.<anonymous>:1822:14)
    at main (evalmachine.<anonymous>:1928:45)
    at evalmachine.<anonymous>:1954:1
    at main (/home/jeffbailey/Programming/gclienttree/dart/dart/frog/frogsh:23725:10)
    at Object.<anonymous> (/home/jeffbailey/Programming/gclienttree/dart/dart/frog/frogsh:24089:1)
    at Module._compile (module.js:432:26)
    at Object..js (module.js:450:10)
    at Module.load (module.js:351:31)
    at Function._load (module.js:310:12)

What version of the product are you using? On what operating system?

Path: .
URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/client/html
Repository Root: http://dart.googlecode.com/svn
Repository UUID: 260f80e4-7a28-3924-810f-c04153c831b5
Revision: 1856
Node Kind: directory
Schedule: normal
Last Changed Author: [email protected]
Last Changed Rev: 1771
Last Changed Date: 2011-11-22 17:12:10 -0800 (Tue, 22 Nov 2011)

Running on a Goobuntu Laptop.

Please provide any additional information below.

This is a reduced test case. It shows more errors than I get in my actual program. The first two are the same, though.

[DartBot]

This comment was originally written by [email protected]

---

Added Area-Frog, Triaged labels.

[jmesserly]

Can you try passing the "--compile-only --out=myapp.js" flag?

By default "frogsh" will try to run the code on the command line (similar to "python" "irb" "node" etc). And so it's not surprising that it doesn't find "window", since it's not running in a browser :)

Once you compile to "myapp.js", add that file to an HTML page and you should be good to go.

frog.py has a "--html" option that might do what you want--it generates an HTML page that references the script, and then opens a browser), but I haven't tried it in a while. And we haven't rolled that option into frogsh yet.

There's also the "htmlconverter.py" script for packaging up your HTML and generated JS code. We used that a lot for our Swarm sample. I don't recall offhand the exact command line arguments, but if you take a look at that script you can probably get it working.

---

Added Invalid label.

[DartBot]

This comment was originally written by [email protected]

---

I did use those options:

jeffbailey@cirrostratus:~/Programming/gittree/nethack-nacl/sys/nacl$ cat test.dart
#import('dart:html');

main() {
  String a = "foo";
  DivElement myDiv = new Element.html("<div>" + a + "</div>");
}
jeffbailey@cirrostratus:/Programming/gittree/nethack-nacl/sys/nacl$ rtest.^C
jeffbailey@cirrostratus:/Programming/gittree/nethack-nacl/sys/nacl$ frogsh --compile-only --out=myapp.js test.dart
/home/jeffbailey/Programming/gclienttree/dart/dart/client/html/release/html.dart:23638:10: warning: can not resolve "innerHTML" on "Element"
    temp.innerHTML = html;
         ^^^^^^^^^
/home/jeffbailey/Programming/gclienttree/dart/dart/client/html/release/html.dart:23646:40: warning: can not resolve "children" on "Element"
      return LevelDom.wrapElement(temp.children.item(tag == 'head' ? 0 : 1));
                                       ^^^^^^^^
jeffbailey@cirrostratus:~/Programming/gittree/nethack-nacl/sys/nacl$

This is also a reduced test case from an app that I'm otherwise writing that is also using those options.

---

Added Triaged label.

[DartBot]

This comment was originally written by [email protected]

---

Appears to be fixed as of 2284.

---

Added Fixed label.