Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dartc: uninitialized final fields don't cause a compile-time error #991

Closed
DartBot opened this issue Dec 27, 2011 · 5 comments
Closed

Dartc: uninitialized final fields don't cause a compile-time error #991

DartBot opened this issue Dec 27, 2011 · 5 comments

Comments

@DartBot
Copy link

DartBot commented Dec 27, 2011

This issue was originally filed by [email protected]


What steps will reproduce the problem?
Run the following test:
class C {
  C() {}
  final _val;
}

main() {
  C c = new C();
}

What is the expected output? What do you see instead?
Expected: compile-time error
Actual: test compiles without errors.

What version of the product are you using? On what operating system?
dartc r2810, Ubuntu 10.04

Please provide any additional information below.
The same applies to the top-level final variables:
final foo;//should be an error

main() {
  Expect.isTrue(foo is List);
}

Tests in co19:
LangSpecTest/05_Variables/A08/t02
LangSpecTest/05_Variables/A03/t04
LangSpecTest/07_Classes/5_Constructors/1/Generative/Constructors/A09/t01

@dgrove
Copy link
Contributor

dgrove commented Jan 2, 2012

Added Area-Compiler, Triaged labels.

@jtmcdole
Copy link
Contributor

jtmcdole commented Jan 3, 2012

Set owner to @jtmcdole.
Added Accepted label.

@jtmcdole
Copy link
Contributor

jtmcdole commented Jan 3, 2012

It should be noted that duplicating initializes also failed to report errors.

@jtmcdole
Copy link
Contributor

jtmcdole commented Jan 4, 2012

http://codereview.chromium.org/9081001/

Marked the wrong bug as fixed.


Added Started label.

@jtmcdole
Copy link
Contributor

jtmcdole commented Jan 4, 2012

dart-bot pushed a commit that referenced this issue Feb 22, 2021
2021-02-22 [email protected] Fix syntax error in test expectation in ffi test (#1002)
2021-02-20 [email protected] #1000: Missing Issue tags added.
2021-02-20 [email protected] Issue #1000: tests updated according to the recent result analysis
2021-02-20 [email protected] Roll failures fixed
2021-02-19 [email protected] #999. Missed experiment flags added
2021-02-19 [email protected] #993. 32 and 64-bit integer tests added
2021-02-19 [email protected] #993. Change test to expect compile error if struct subclass created by the constructor
2021-02-19 [email protected] #993. Remove tests that run "nm" command
2021-02-18 [email protected] #993. More ffi tests added
2021-02-18 [email protected] Instantiate-to-bounds tests apdated according to the SDK Issues 44223, 42446 evaluation.
2021-02-17 [email protected] Issue #535: nnbd-strong requirement added to the tests, more tests for constant evaluation and canonicalization added.
2021-02-17 [email protected] Some of type aliases tests fixed
2021-02-17 [email protected] #993. More Struct tests added
2021-02-16 [email protected] Issue #535: more tests for constant evaluation and canonicalization added.
2021-02-12 [email protected] Fixes #994: test expectesions updated according to the recent SDK changes.
2021-02-12 [email protected] #993. More Struct tests added
2021-02-12 [email protected] Merge remote-tracking branch 'origin/master'
2021-02-12 [email protected] #993. NativeType and Struct tests added
2021-02-11 [email protected] Fixes #991: tests updated according to the recent SDK changes.
2021-02-08 [email protected] #993. sizeOf() tests added
2021-02-05 [email protected] #993. More tests for DynamicLibrary added
2021-02-04 [email protected] #993. DynamicLibrary constructors tests added
2021-02-03 [email protected] #993. co19 ffi tests. Initial commit
2021-02-02 [email protected] Fixes #992. Boolean conditional evaluation tests added
2021-02-01 [email protected] Fixes #990: tests updated according to the recent SDK changes.
2021-01-28 [email protected] Fixes #979: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-28 [email protected] Fixes #984: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-27 [email protected] Fixes #989. Runtime type equality operator tests added
2021-01-26 [email protected] Fixes #988: Static warning checks corrected.
2021-01-25 [email protected] Fixes #987. Local variables and inference tests added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I78ba37f9c74d2afc360ef5fbd51d01ab75239fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186146
Reviewed-by: Jonas Termansen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants