Properly handle Windows file: URLs on Node.js #30098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds logic to the JS implementation of URI to determine whether the code is running on Windows under Node.js.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 7, 2017
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 7, 2017
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 7, 2017
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 7, 2017
We aren't running Node tests here until dart-lang/sdk#30098 lands.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 7, 2017
lrhn
requested changes
Jul 12, 2017
| static bool get _isWindows => _isWindowsCached; | ||
|
|
||
| static final bool _isWindowsCached = | ||
| JS('bool', 'process !== undefined && process.platform == "win32"'); |
There was a problem hiding this comment.
It looks unsafe. Using "process" with no prefix requires "process" to exist, otherwise the access throws.
Maybe use typeof to avoid that:
typeof process != "undefined" && Object.prototype.toString.call(process) === "[object process]" && process.platform === "win32"(This also strengthens the check for node.js since that's the only known platform that has a object class named "process")
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
May 4, 2018
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
May 28, 2018
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
May 28, 2018
Remove the workaround for dart-lang/sdk#30098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to the JS implementation of URI to determine whether
the code is running on Windows under Node.js.