-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web_audio is not part sky_engine #53242
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/321340 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you just fix the formatting?
|
||
indexed_db_sdk_sources = [ | ||
"dart2js/indexed_db_dart2js.dart", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the new line here and in the svg_sources.gni below (make sure to run gn format ...
) on these newly added files.
Sorry I'm just noticing this PR. It may be worth circling back on the conversation about how we want to expose these APIs. I'll add some comments to flutter/flutter#49849 as well, but the quick summary is this:
So the question is: Do we still make this change today and wait for |
https://dart-review.googlesource.com/c/sdk/+/321340 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/321340 has been updated with the latest commits from this pull request. |
If we're going to need users to migrate a couple months from now anyways, it makes sense for me to say that we should hold off and have users use I don't know what the usage is like for |
@sigmundch @srujzs I think it is worth highlighting the following: people can already use these libraries with |
Makes sense - I approved the PR in gerrit, so feel free to move forward. Just wanted to clarify to others on this thread that if you use |
Contribution guidelines:
dart format
.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.