Skip to content

Commit

Permalink
Fix beta build and ignore dev channel for now (#4425)
Browse files Browse the repository at this point in the history
Tracking the work to re-enable the dev build in
#4424
  • Loading branch information
parlough authored Dec 9, 2022
1 parent 57f421b commit da74e86
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [stable, beta, dev]
sdk: [stable, beta]
steps:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
with:
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ RUN set -eu; \
DART_SHA256="f8c6d7e1b0f090c536a64a6a130b065533efd83c290f4510f42325389a0c27a5"; \
SDK_ARCH="arm64";; \
amd64_beta) \
DART_SHA256="3de768ca2def7f953f8fe17c5d4e332cd18f3220ecdf28bb331b007edf58551e"; \
DART_SHA256="0cd028e661deded1b141348ebab1aa82814ee5a73ef226ff6c40ea225ff311a2"; \
SDK_ARCH="x64";; \
arm64_beta) \
DART_SHA256="34ddc9dac6022102c212465dde93dba8cad65a5fe2d8b54646c1a6114e58b48c"; \
DART_SHA256="6c9384814d1d516eec616f40d22df161e219eb15d730105a28bf260f3274b4ed"; \
SDK_ARCH="arm64";; \
amd64_dev) \
DART_SHA256="1b8c1d58e4b8773be325152b16cc86edaac8b2e885ca7d629486b5e3af97678a"; \
DART_SHA256="1d11accc2253df64b927c2b631b9921e253943d6b14e338afa3d7e8f84f98af4"; \
SDK_ARCH="x64";; \
arm64_dev) \
DART_SHA256="7a31c77239860b22c42029f8090f4c7fd4b52924c67406c1bbc26637d477a4f6"; \
DART_SHA256="8545067be105012f6d0dbb4426b7a28da6928f6f0e3d69e391cfd16dc4dfffbc"; \
SDK_ARCH="arm64";; \
esac; \
SDK="dartsdk-linux-${SDK_ARCH}-release.zip"; \
Expand Down
2 changes: 1 addition & 1 deletion examples/analysis/analyzer-results-beta.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Analyzing analysis...

error - lib/strict_modes.dart:15:7 - The argument type 'dynamic' can't be assigned to the parameter type 'List<String>'. - argument_type_not_assignable
info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
info - lib/lint.dart:9:19 - Unnecessary empty statement. Try removing the empty statement or restructuring the code. - empty_statements
info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
info - lib/strict_modes.dart:22:17 - The type argument(s) of 'Map' can't be inferred. Use explicit type argument(s) for 'Map'. - inference_failure_on_collection_literal
info - lib/strict_modes.dart:33:3 - The generic type 'List<dynamic>' should have explicit type arguments but doesn't. Use explicit type arguments for 'List<dynamic>'. - strict_raw_type
Expand Down
10 changes: 4 additions & 6 deletions tool/get-dart/dart_sdk_archive/lib/src/run_app.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'dart:async';
import 'dart:html';

import 'package:dart_sdk_archive/src/version_selector.dart';
Expand Down Expand Up @@ -31,10 +32,7 @@ Future<void> runApp() async {
querySelector('#dev-os') as SelectElement,
);

// ignore: unawaited_futures
stableSelector.init();
// ignore: unawaited_futures
betaSelector.init();
// ignore: unawaited_futures
devSelector.init();
unawaited(stableSelector.init());
unawaited(betaSelector.init());
unawaited(devSelector.init());
}

0 comments on commit da74e86

Please sign in to comment.