Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate search form in the side navigation #5295

Closed
Tracked by #5251
atsansone opened this issue Oct 26, 2023 · 0 comments · Fixed by #5319
Closed
Tracked by #5251

Remove duplicate search form in the side navigation #5295

atsansone opened this issue Oct 26, 2023 · 0 comments · Fixed by #5319
Assignees
@parlough
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged t.a11y Relates to an accessibility concern

Comments

@atsansone
Copy link
Contributor

atsansone commented Oct 26, 2023 •
edited
Loading

The input tag of the search form needs an accepted type attribute: image or submit. The current type, search, is valid HTML but not valid for WCAG.

Error: This form does not contain a submit button, which creates issues for those who cannot submit the form using the keyboard. Submit buttons are INPUT elements with type attribute "submit" or "image", or BUTTON elements with type "submit" or omitted/invalid.

Code: H32 #WCAG2AA.Principle3.Guideline3_2.3_2_2.H32.2

Location: #navbarSupportedContent > div:nth-child(2) > form

<form action="/search/" class="site-header__search form-inline"><input class="site-h...</form>
@atsansone atsansone mentioned this issue Oct 26, 2023
Open
26 tasks
@atsansone atsansone added p1-high Major but not urgent concern: Resolve in months. Update each month. t.a11y Relates to an accessibility concern e2-days Can complete in < 5 days of normal, not dedicated, work st.triage.ltw Indicates Lead Tech Writer has triaged labels Oct 27, 2023
parlough added a commit that referenced this issue Nov 5, 2023
@parlough
Avoid duplicated IDs in search form
8912637 
Fixes #5295
parlough added a commit that referenced this issue Nov 5, 2023
@parlough
Avoid duplicated search box IDs
4aec2a8 
Fixes #5295
@parlough parlough mentioned this issue Nov 5, 2023
Merged
parlough added a commit that referenced this issue Nov 7, 2023
@parlough
Avoid duplicated search box IDs (#5319)
86cb5b7 
The `name` field on an input is used for submitting the search, so it's
okay for the IDs to be different, but the names to remain the same.

Fixes #5295
MaryaBelanger pushed a commit that referenced this issue Nov 14, 2023
@parlough @MaryaBelanger
Avoid duplicated search box IDs (#5319)
13687f7 
The `name` field on an input is used for submitting the search, so it's
okay for the IDs to be different, but the names to remain the same.

Fixes #5295
atsansone pushed a commit to atsansone/site-www that referenced this issue Jan 26, 2024
@parlough
Avoid duplicated search box IDs (dart-lang#5319)
e442159 
The `name` field on an input is used for submitting the search, so it's
okay for the IDs to be different, but the names to remain the same.

Fixes dart-lang#5295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e2-days Can complete in < 5 days of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged t.a11y Relates to an accessibility concern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid duplicated search box IDs dart-lang/site-www
2 participants
@atsansone @parlough