Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication of in-page ToC #5296

Closed
Tracked by #5251
atsansone opened this issue Oct 27, 2023 · 0 comments · Fixed by #5317
Closed
Tracked by #5251

Fix duplication of in-page ToC #5296

atsansone opened this issue Oct 27, 2023 · 0 comments · Fixed by #5317
Assignees
@parlough
Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged t.a11y Relates to an accessibility concern

Comments

@atsansone
Copy link
Contributor

atsansone commented Oct 27, 2023 •
edited
Loading

a11y script found duplicate ID for the in-page ToC. The ToC is rendered twice: once for desktop layout and once for mobile layout. This raises a WCAG F77 error on pages with in-page ToCs. This causes issues with accessibility technology. This should be fixed.
@atsansone atsansone mentioned this issue Oct 27, 2023
Open
26 tasks
@atsansone atsansone added p1-high Major but not urgent concern: Resolve in months. Update each month. t.a11y Relates to an accessibility concern e1-hours Can complete in < 8 hours of normal, not dedicated, work st.triage.ltw Indicates Lead Tech Writer has triaged labels Oct 27, 2023
@parlough parlough self-assigned this Oct 28, 2023
@parlough parlough mentioned this issue Nov 4, 2023
Merged
parlough added a commit that referenced this issue Nov 7, 2023
@parlough
Fix and remove duplicated toc ID (#5317)
706663a 
We use a TOC generated from a plugin, so we need to do the replacement
manually.

Fixes #5296
Fixes #5302
MaryaBelanger pushed a commit that referenced this issue Nov 14, 2023
@parlough @MaryaBelanger
Fix and remove duplicated toc ID (#5317)
71fc583 
We use a TOC generated from a plugin, so we need to do the replacement
manually.

Fixes #5296
Fixes #5302
atsansone pushed a commit to atsansone/site-www that referenced this issue Jan 26, 2024
@parlough
Fix and remove duplicated toc ID (dart-lang#5317)
fcf6db5 
We use a TOC generated from a plugin, so we need to do the replacement
manually.

Fixes dart-lang#5296
Fixes dart-lang#5302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged t.a11y Relates to an accessibility concern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and remove duplicated toc ID dart-lang/site-www
2 participants
@atsansone @parlough