Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .packages/packages discussions for 1.19 #129

Merged
merged 3 commits into from
Sep 7, 2016
Merged

Update .packages/packages discussions for 1.19 #129

merged 3 commits into from
Sep 7, 2016

Conversation

kwalrath
Copy link
Contributor

@kwalrath kwalrath commented Sep 6, 2016 •
edited
Loading

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 6, 2016
@kwalrath kwalrath mentioned this pull request Sep 6, 2016
Closed
@kwalrath
Copy link
Contributor Author

kwalrath commented Sep 6, 2016

@Sfshaza could you please review?

cc: @munificent, @nex3, @kevmoo

@Sfshaza
Copy link

Sfshaza commented Sep 7, 2016

I wish the coming-release.html include had a different name - something specific to packages, but that's a nit. Overall, LGTM!

@kwalrath kwalrath merged commit adfacb7 into master Sep 7, 2016
@kwalrath kwalrath deleted the packages-dir branch September 7, 2016 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwalrath @Sfshaza @googlebot