[DO NOT COMMIT] Fix highlights in the diagnostics page #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Yeah!
Not as bad as it might sound. The markdown file is generated, so we could automatically convert from one form to the other if need be.
I'll hold off on sending the URLs from server (or printing them from the command-line) until we've decided. After we start producing URLs we'll need to have a process in place to change them; otherwise users using older versions of the SDK will get obsolete URLs, and that wouldn't be a good UX.
Yep. We noticed that last time too. |
|
Closing in favor of #1790. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The good news: I got the highlights working, and you can see them at https://kw-www-dartlang-1.firebaseapp.com/guides/diagnostics.
The bad news: to get the highlights working, I had to change ```dart to
{% prettify dart %}. Yuck. This is a known problem, and I’ve created #1744 to track it.Other issues to ponder:
ambiguous_set_or_map_literal_either look the same.
/cc @domesticmouse @legalcodes @bwilkerson @johnpryan