Clarify switch expression usage #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b4b6352): https://dart-dev--pr4887-switch-exp-oiqmu4af.web.app (expires Tue, 23 May 2023 20:14:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
atsansone
approved these changes
May 16, 2023
Co-authored-by: Anthony Sansone <[email protected]>
munificent
approved these changes
May 16, 2023
parlough
approved these changes
May 16, 2023
parlough
added
st.RFM.%
Co-authored-by: Parker Lougheed <[email protected]>
rmacnak-google
pushed a commit
to rmacnak-google/site-www
that referenced
this pull request
Sep 5, 2023
Fixes dart-lang#4865 --------- Co-authored-by: Anthony Sansone <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think "return a value into some expression statement" in lines 136 and 137 exactly makes sense:
I could also just say "if you need to start an expression statement with a switch, use a switch statement" if that's clearer. This seems to be where the confusion is.
Fixes #4865
Didn't change the bullet list, just moved it below the example since it's kind of weird to list out the syntax differences without having shown an example yet.