This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Avoid uninitialized final fields. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't actually invalid Dart 2 after all, since the class has a factory constructor and therefore does not get a default constructor. The change could still be integrated as a matter of style, but it doesn't block anything. |
nex3
pushed a commit
to nex3/source_span
that referenced
this pull request
Jul 2, 2024
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abstract
SourceSpanclass uses uninitialized final fields to put getters into the interface. This is invalid Dart 2 and blocks dart-lang/sdk#33022