This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Fix typo and add example to message() and highlight() #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
suggested changes
Dec 13, 2018
lib/src/span.dart
Outdated
| /// highlight the span's text. If it's `true`, it indicates that the text | ||
| /// should be highlighted using the default color. If it's `false` or `null`, | ||
| /// it indicates that the text shouldn't be highlighted. | ||
| /// it indicates an ANSI terminal color escape that should be used to |
There was a problem hiding this comment.
It's probably a good idea to link "ANSI terminal color escape" to https://en.wikipedia.org/wiki/ANSI_escape_code#Colors.
lib/src/span.dart
Outdated
| /// should be highlighted using the default color. If it's `false` or `null`, | ||
| /// it indicates that the text shouldn't be highlighted. | ||
| /// it indicates an ANSI terminal color escape that should be used to | ||
| /// highlight the span's text (e.g. `"\u001b[31m"` will color red). If it's |
Add a link, s/e.g./for example,/
nex3
approved these changes
Dec 13, 2018
nex3
pushed a commit
to nex3/source_span
that referenced
this pull request
Jul 2, 2024
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo is s/ANSII/ANSI/ and I found the doc insufficient in describing what format the ANSI code should be supplied in.