This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Revert "Be more efficient with String.fromCharCodes (#44)" #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a5f8ead. This caused an unknown issue in rare cases with the test package.
|
cc @kevmoo |
grouma
approved these changes
Nov 14, 2019
nex3
added a commit
to nex3/source_span
that referenced
this pull request
Jul 2, 2024
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
…_span#44)" (dart-lang/source_span#46) This reverts commit ff83890. This caused an unknown issue in rare cases with the test package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a5f8ead.
This caused an unknown issue in rare cases with the test package.