Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

Remove workaround for SDK bug. #63

Merged
merged 1 commit into from
Sep 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 1.8.0-nullsafety.3

* Remove workaround for https://github.com/dart-lang/sdk/issues/43136, which is
now fixed.

# 1.8.0-nullsafety.2

* Revert unnecessary null check fix (sdk fix wont land in 2.10 stable).
Expand Down
4 changes: 1 addition & 3 deletions lib/src/highlighter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,7 @@ class Highlighter {
? _primaryColor
: _secondaryColor;
var foundCurrent = false;
for (var tmp in highlightsByColumn) {
// Work around https://github.com/dart-lang/sdk/issues/43136
final highlight = tmp;
for (var highlight in highlightsByColumn) {
final startLine = highlight?.span.start.line;
final endLine = highlight?.span.end.line;
if (current != null && highlight == current) {
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: source_span
version: 1.8.0-nullsafety.2
version: 1.8.0-nullsafety.3-dev

description: A library for identifying source spans and locations.
homepage: https://github.com/dart-lang/source_span

environment:
# This must remain a tight constraint until nnbd is stable
sdk: '>=2.10.0-0.0 <2.11.0'
sdk: '>=2.11.0-0.0 <2.11.0'

dependencies:
charcode: '>=1.2.0-nullsafety <1.2.0'
Expand Down