Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests for dart 2 #21

Merged
merged 3 commits into from
May 1, 2018
Merged

fix tests for dart 2 #21

merged 3 commits into from
May 1, 2018

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 requested a review from natebosch May 1, 2018 15:03
@jakemac53
Copy link
Contributor Author

cc @keertip

Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

@jakemac53
Copy link
Contributor Author

looks like the stream_channel_test also needs some fixes, updating soon

@jakemac53
Copy link
Contributor Author

I can't seem to fix up the last test - going to merge this for now while I keep working on that.

@jakemac53 jakemac53 merged commit 923a4fb into master May 1, 2018
@jakemac53 jakemac53 deleted the fix-dart2-tests branch May 1, 2018 20:21
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart 2 runtime failures in tests
3 participants