Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a remaining Dart 2 issue #23

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix a remaining Dart 2 issue #23

merged 1 commit into from
May 2, 2018

Conversation

nex3
Copy link
Member

@nex3 nex3 commented May 2, 2018

We had some unnecessary typed wrappers that were interfering with
runtime type arguments.

Closes dart-lang/tools#1870

We had some unnecessary typed wrappers that were interfering with
runtime type arguments.

Closes #22
@nex3 nex3 requested a review from keertip May 2, 2018 00:04
@jakemac53
Copy link
Contributor

Thanks @nex3 for digging into this one :)

Copy link
Contributor

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nex3 nex3 merged commit d9ee6b8 into master May 2, 2018
@nex3 nex3 deleted the fix-dart2 branch May 2, 2018 19:51
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
We had some unnecessary typed wrappers that were interfering with
runtime type arguments.

Closes dart-lang/stream_channel#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream_channel_test fails in dart 2
4 participants