Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional new/const #37

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Remove optional new/const #37

merged 2 commits into from
Mar 26, 2019

Conversation

natebosch
Copy link
Member

  • Run dartfmt --fix.
  • Update version to start working towards next breaking change.
  • Update minimum SDK to 2.0.0 stable.

- Run `dartfmt --fix`.
- Update version to start working towards next breaking change.
- Update minimum SDK to 2.0.0 stable.
@@ -1,12 +1,12 @@
name: stream_channel
version: 1.6.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that there are not any breaking changes yet I would just do a dot release

also, please add a corresponding changelog entry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points for enabling the corresponding lints!

## 1.6.9

* Require `2.0.0` or newer SDK.
* Drop unnecessary `new` and `const`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be dropped, right? Doesn't affect end users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ Jake asked for an entry

#37 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakemac53 – you silly

@natebosch natebosch merged commit 1df5483 into master Mar 26, 2019
@natebosch natebosch deleted the no-new branch March 26, 2019 21:00
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
- Run `dartfmt --fix`.
- Update version to start working towards next breaking change.
- Update minimum SDK to 2.0.0 stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants