-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove optional new/const #37
Conversation
- Run `dartfmt --fix`. - Update version to start working towards next breaking change. - Update minimum SDK to 2.0.0 stable.
@@ -1,12 +1,12 @@ | |||
name: stream_channel | |||
version: 1.6.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that there are not any breaking changes yet I would just do a dot release
also, please add a corresponding changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points for enabling the corresponding lints!
## 1.6.9 | ||
|
||
* Require `2.0.0` or newer SDK. | ||
* Drop unnecessary `new` and `const`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be dropped, right? Doesn't affect end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ Jake asked for an entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakemac53 – you silly
- Run `dartfmt --fix`. - Update version to start working towards next breaking change. - Update minimum SDK to 2.0.0 stable.
dartfmt --fix
.