Enable and fix a number of lints, test on oldest supported SDK #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump min SDK to Dart 2.0
natebosch
approved these changes
May 6, 2019
| /// Returns a matcher that asserts that a closure throws a | ||
| /// [StringScannerException] with the given [text]. | ||
| Matcher throwsStringScannerException(String text) => | ||
| throwsA(const TypeMatcher<StringScannerException>() |
There was a problem hiding this comment.
isA<StringScannerException>? Or does the test with isA require a newer SDK?
There was a problem hiding this comment.
I'd have to bump to 2.2 I think...
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…lang/string_scanner#15) Bump min SDK to Dart 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump min SDK to Dart 2.0