-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a type error that occurs comparing two large maps with `deepEqual…
…s`. (#2442) Closes #2442 Avoid inference forcing a `List<Iterable<String>>` which results in a type error inserting a range into a list requiring `List<String>`. Add a test for collection truncating which would have failed with a type error before this fix.
- Loading branch information
1 parent
b5bfba5
commit 073ef8b
Showing
3 changed files
with
35 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
import 'package:checks/checks.dart'; | ||
import 'package:checks/context.dart'; | ||
import 'package:test/scaffolding.dart'; | ||
|
||
void main() { | ||
group('literal', () { | ||
group('truncates large collections', () { | ||
const maxUntruncatedCollection = 25; | ||
final largeList = | ||
List<int>.generate(maxUntruncatedCollection + 1, (i) => i); | ||
test('in lists', () { | ||
check(literal(largeList)).last.equals('...]'); | ||
}); | ||
test('in sets', () { | ||
check(literal(largeList.toSet())).last.equals('...}'); | ||
}); | ||
test('in iterables', () { | ||
check(literal(largeList.followedBy([]))).last.equals('...)'); | ||
}); | ||
test('in maps', () { | ||
final map = Map<int, int>.fromIterables(largeList, largeList); | ||
check(literal(map)).last.equals('...}'); | ||
}); | ||
}); | ||
}); | ||
} |