Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for legacy iframe communication #2099

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

natebosch
Copy link
Member

Closes #2065

All known iframe side implementations have been updated to send the
'port' message with an immediately available channel over the map and
the extra window message.

Move some still relevant assert into the implementation for the
current approach.

Closes #2065

All known iframe side implementations have been updated to send the
`'port'` message with an immediately available channel over the map and
the extra window message.

Move some still relevant `assert` into the implementation for the
current approach.
@natebosch natebosch requested a review from jakemac53 September 21, 2023 00:09
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to run into the issue with missing flutter_test dependencies again?

@natebosch
Copy link
Member Author

Are we going to run into the issue with missing flutter_test dependencies again?

We shouldn't. The two sides of this particular dependency are managed by dependencies in the flutter checkout, not the users project.

flutter/flutter#131881 updated flutter_tools to send the 'port' message, and the compiled host.dart.js is used from the flutter repo pub solve.
https://github.com/flutter/flutter/blob/4d8e390c1be6237ab45df9c57b87e50e499056db/packages/flutter_tools/lib/src/test/flutter_web_platform.dart#L156-L157

This would only be a problem if the iframe code could be an old version - but that is controlled by the test platform, not the pub dependency.

@natebosch natebosch merged commit 7ec1bbf into master Sep 25, 2023
@natebosch natebosch deleted the legacy-frame-channel branch September 25, 2023 18:48
natebosch added a commit that referenced this pull request Jan 17, 2025
Cleanup following #2065

The support for legacy test suite communication was dropped in #2099 but
I missed a change in this comment which still describes the difference.
natebosch added a commit that referenced this pull request Jan 17, 2025
Cleanup following #2065

The support for legacy test suite communication was dropped in #2099 but
I missed a change in this comment which still describes the difference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the communication between the browser host and iframe
2 participants