Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock CI: Ignore deprecation and skip a test #2445

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented Jan 14, 2025

Unblock CI until these can be migrated and fixed.

Unblock CI until these can be migrated.

Recompile host.dart
@natebosch natebosch requested a review from a team as a code owner January 14, 2025 22:50
@natebosch natebosch requested review from jakemac53 and removed request for a team January 14, 2025 22:50
Copy link

github-actions bot commented Jan 14, 2025

PR Health

No user facing changes.
@kevmoo
Copy link
Member

kevmoo commented Jan 14, 2025

Or, you know, we could fix these! 😄

@kevmoo
Copy link
Member

kevmoo commented Jan 14, 2025

At least a TODO and an open issue to migrate?

@natebosch natebosch changed the title Ignore deprecates for dart:js_util Ignore deprecations for dart:js_util Jan 14, 2025
@natebosch
Copy link
Member Author

At least a TODO and an open issue to migrate?

#2447

I don't see value in a TODO when a grep for dart:js_util already has 100% fidelity.

@natebosch
Copy link
Member Author

Holding back the recompile since that is triggering some other CI bug

See #2288

These seem to be failing to load.
@natebosch natebosch changed the title Ignore deprecations for dart:js_util Unblock CI: Ignore deprecation and skip a test Jan 17, 2025
@natebosch
Copy link
Member Author

hmm, I didn't know that we don't support making configuration specific to an OS when it's running on the browser... I thought that was possible but when we evaluate the OnPlatform selectors the browser tests always treat the OS as empty.

if (runtime.isBrowser && os != OperatingSystem.none) {
throw ArgumentError('No OS should be passed for runtime "$runtime".');
}

@natebosch
Copy link
Member Author

linux firefox tests are also not working, we can skip these entirely on firefox for now to get unblocked.

@natebosch natebosch merged commit b5bfba5 into master Jan 17, 2025
60 checks passed
@natebosch natebosch deleted the deprecated-js-util branch January 17, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants