Add a SuitePlatform class #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This encapsulates all the information about the platform on which a suite runs, and which platform selectors can select for. Currently it just includes the runtime and the operating system, but eventually it could include whether we're running internally to Google, or which compiler is in use.
This clarifies the distinction between TestPlatform and SuitePlatform, and uses a more specific word rather than a more general one. Unfortunately, it does mean that we have some user-facing interfaces (the --platform flag, the override_platforms and define_platforms configuration fields) that now use different terminology than the test runner. It would be possible to migrate those to refer to "runtime" as well, but seeing as --platform in particular is very widely-used *and* matches up nicely with --preset (-p vs -P) I'm inclined to think it's not worth the effort.
grouma
reviewed
Feb 27, 2018
|
|
||
| /// The operating system on which the suite is running. | ||
| /// | ||
| /// This will always be [OperatingSystem.none] if `runtime.isBrowser` is |
There was a problem hiding this comment.
Should we add another value to operating system that is 'Browser'?
There was a problem hiding this comment.
That's just what "none" means. I like the term "none" though, since it's future-proof for other platforms that may be OS-independent.
| @@ -65,7 +65,7 @@ final ArgParser _parser = (() { | |||
| abbr: 'p', | |||
| help: 'The platform(s) on which to run the tests.\n' | |||
| '[vm (default), ' | |||
| '${allPlatforms.map((platform) => platform.identifier).join(", ")}]', | |||
| '${allRuntimes.map((runtime) => runtime.identifier).join(", ")}]', | |||
There was a problem hiding this comment.
Should we add some internal comments here stating platforms map to runtimes due to historical reasons?
grouma
approved these changes
Feb 27, 2018
|
|
||
| /// The operating system on which the suite is running. | ||
| /// | ||
| /// This will always be [OperatingSystem.none] if `runtime.isBrowser` is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates all the information about the platform on which a
suite runs, and which platform selectors can select for. Currently it
just includes the runtime and the operating system, but eventually it
could include whether we're running internally to Google, or which
compiler is in use.
This also renames
TestPlatformtoRuntime, which clarifies thedistinction between
TestPlatformandSuitePlatform, and uses amore specific word rather than a more general one. Unfortunately, it
does mean that we have some user-facing interfaces (the
--platformflag, the
override_platformsanddefine_platformsconfigurationfields) that now use different terminology than the test runner.
It would be possible to migrate those to refer to "runtime" as well,
but seeing as
--platformin particular is very widely-used andmatches up nicely with
--preset(-pvs-P) I'm inclined to thinkit's not worth the effort.