This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
handle exceptions thrown to zone handlers in @failingTests #7
+26
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scheglov, this updates the way that
@failingTest
annotations are handled to catch exceptions from timer tasks (that would fail the test, but would not be passed back from any Future returned by the test). I see these types of failures in some analysis server integration tests (the exception is caught in a timer task, that calls package:testfail()
, and fails the test).