Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

handle exceptions thrown to zone handlers in @failingTests #7

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

devoncarew
Copy link
Member

@scheglov, this updates the way that @failingTest annotations are handled to catch exceptions from timer tasks (that would fail the test, but would not be passed back from any Future returned by the test). I see these types of failures in some analysis server integration tests (the exception is caught in a timer task, that calls package:test fail(), and fails the test).

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@devoncarew devoncarew changed the title handle exceptions to zone handlers in @failingTests handle exceptions thrown to zone handlers in @failingTests Dec 7, 2017
@devoncarew devoncarew merged commit 97d4dd7 into master Dec 7, 2017
@devoncarew
Copy link
Member Author

@scheglov, can you publish a new version of this package?

@scheglov
Copy link
Contributor

scheglov commented Dec 7, 2017

mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…failing_test

handle exceptions thrown to zone handlers in @failingTests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants