Enable file watcher tests on Windows #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Nov 22, 2023
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
* Enable file watcher tests on Windows * Add additional test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to track down dart-lang/sdk#54116 (which looks like the
readyevent not firing), I noticed these file watcher tests were skipped for Windows.They all pass (at least for me locally), so I don't think they should be skipped.
I also added a new test for what I thought was the cause of dart-lang/sdk#54116 but it's also passing, so I need to do some more debugging of that 🤷♂️