chore: set max SDK version to <3.0.0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Jul 16, 2018
pubspec.yaml
Outdated
| @@ -1,16 +1,21 @@ | |||
| name: watcher | |||
| version: 0.9.7+9 | |||
| version: 0.9.8 | |||
There was a problem hiding this comment.
@kevmoo: maybe this would be a good time to bump this up to 1.0.0?
chalin
force-pushed
the
chalin-max-sdk-to-3-0716
branch
from
413f655 to
b6fcf68
Compare
chalin
force-pushed
the
chalin-max-sdk-to-3-0716
branch
from
b6fcf68 to
d3c3cc4
Compare
munificent
approved these changes
Jul 17, 2018
| @@ -17,8 +17,7 @@ void main() { | |||
| sharedTests(); | |||
|
|
|||
| test('DirectoryWatcher creates a LinuxDirectoryWatcher on Linux', () { | |||
| expect( | |||
| new DirectoryWatcher('.'), new isInstanceOf<LinuxDirectoryWatcher>()); | |||
| expect(new DirectoryWatcher('.'), TypeMatcher<LinuxDirectoryWatcher>()); | |||
There was a problem hiding this comment.
If you're going to remove one new, should probably remove the other too. Or just keep the new for now and we'll remove them all later.
There was a problem hiding this comment.
I'll add back the new. We can run dartfmt --fix later (so as to keep this PR simple).
chalin
force-pushed
the
chalin-max-sdk-to-3-0716
branch
2 times, most recently
from
1a16bde to
036fe88
Compare
chalin
force-pushed
the
chalin-max-sdk-to-3-0716
branch
from
036fe88 to
42b0c6f
Compare
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.