Add missing return to fix analysis #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
suggested changes
Aug 3, 2018
lib/src/async_queue.dart
Outdated
| @@ -59,12 +59,13 @@ class AsyncQueue<T> { | |||
| /// the process was cancelled. | |||
| Future _processNextItem() { | |||
| var item = _items.removeFirst(); | |||
| return _processor(item).then((_) { | |||
| return _processor(item).then((_) async { | |||
| if (_items.isNotEmpty) return _processNextItem(); | |||
There was a problem hiding this comment.
If the method is async, this should be return await. Otherwise it's easy to accidentally refactor without realizing this is asynchronous.
nex3
reviewed
Aug 3, 2018
lib/src/async_queue.dart
Outdated
| if (_items.isNotEmpty) return _processNextItem(); | ||
|
|
||
| // We have drained the queue, stop processing and wait until something | ||
| // has been enqueued. | ||
| _isProcessing = false; | ||
| return await null; |
There was a problem hiding this comment.
I meant the other return should be return await. There's no use in awaiting null.
nex3
approved these changes
Aug 3, 2018
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
* Add missing return to fix analysis * address comment * Update async_queue.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with bleeding edge.