Fix missing events for files with directory prefix #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #83 If any event had the same leading characters as a directory that was also changed it would get filtered out. For example if both `lib/b/` and `lib/b.dart` have change events we'd lose the events for `lib/b.dart` because it shared a prefix with a directory, even though it isn't contained within that directory.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
) Fixes dart-lang/watcher#83 If any event had the same leading characters as a directory that was also changed it would get filtered out. For example if both `lib/b/` and `lib/b.dart` have change events we'd lose the events for `lib/b.dart` because it shared a prefix with a directory, even though it isn't contained within that directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#1722
If any event had the same leading characters as a directory that was
also changed it would get filtered out. For example if both
lib/b/andlib/b.darthave change events we'd lose the events forlib/b.dartbecause it shared a prefix with a directory, even though it isn't
contained within that directory.