Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reason to a flaky assert #88

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Add a reason to a flaky assert #88

merged 2 commits into from
Apr 28, 2020

Conversation

natebosch
Copy link
Member

We have seen a case of this assert failing on linux on travis. Add a
reason which includes the path to hopefully get more information if we
see it again.

We have seen a case of this assert failing on linux on travis. Add a
reason which includes the path to hopefully get more information if we
see it again.
@natebosch natebosch requested a review from grouma April 16, 2020 19:17
@natebosch
Copy link
Member Author

Failure looked like:

00:20 +66 -1: test/file_watcher/polling_test.dart: notifies when a file is modified multiple times [E]
  'file:///home/travis/build/dart-lang/watcher/test/utils.dart': Failed assertion: line 61 pos 12: 'p.isRelative(path) && !path.startsWith('..')': is not true.
  dart:core                                            _AssertionError._throwNew
  test/utils.dart 61:12                                startWatcher.<fn>
  package:watcher/src/stat.dart 27:29                  modificationTime
  ===== asynchronous gap ===========================
  dart:async                                           _AsyncAwaitCompleter.completeError
  package:watcher/src/stat.dart                        modificationTime
  ===== asynchronous gap ===========================
  dart:async                                           _asyncThenWrapperHelper
  package:watcher/src/file_watcher/polling.dart        _PollingFileWatcher._poll
  package:watcher/src/file_watcher/polling.dart 49:50  new _PollingFileWatcher.<fn>
  ===== asynchronous gap ===========================
  dart:async                                           new Timer.periodic
  package:watcher/src/file_watcher/polling.dart 49:20  new _PollingFileWatcher
  package:watcher/src/file_watcher/polling.dart 19:18  new PollingFileWatcher.<fn>
  package:watcher/src/resubscribable.dart 49:21        new ResubscribableWatcher.<fn>

@natebosch
Copy link
Member Author

now it seems to be failing more consistently. I have no idea what happened. This passed in #86

@natebosch
Copy link
Member Author

This is still flaky. I think it may have something to do with concurrency using test_descriptor or something like that - it seems that d.sandbox changes at an unexpected time.

I'm going to merge this as is, even though it's not quite making it clear what is happening.

@natebosch natebosch merged commit aa284bd into master Apr 28, 2020
@natebosch natebosch deleted the assert-reason branch April 28, 2020 23:10
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
We have seen a case of this assert failing on linux on travis. Add a
reason which includes the path to hopefully get more information if we
see it again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants