-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChromeProxyService does not implement setIsolatePauseMode #1627
Comments
@elliette can you take a look at this when you have a chance? @DanTup ideally, yes, we should fall back onto the deprecated RPCs. Practically, it'll just be easier to fix this in DWDS since most of |
That sounds reasonable to me, although if there's a chance this can't be fixed in DWDS (and rolled into Flutter) before the next major release, it would be good to consider the options. This is blocking migrating VS Code users over to the new SDK DAPs (which is where any new work will be done, with the old DAPs frozen for anything but major fixes). Thanks! |
As far as I know, this was completed a while back. Feel free to re-open if there's anything outstanding. |
I'm preparing to switch VS Code users over from the debug adapter shipped in Dart-Code to the ones that are now shipping in the Dart+Flutter SDKs. However I found that trying to run Flutter apps on the Chrome device fails with this error:
I believe the issue is that in dart-lang/sdk@0cad0e7 the debug adapter was switched from
setExceptionPauseMode
tosetIsolatePauseMode
and that's not implemented by the proxy.@bkonyi slightly related - should
package:vm_service
handle falling back to the old method if the VM Service it's connected to doesn't support it? If not, should the DAP code be switched back to the old method until this is implemented?The text was updated successfully, but these errors were encountered: