Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromeProxyService does not implement setIsolatePauseMode #1627

Closed
DanTup opened this issue May 26, 2022 · 3 comments
Closed

ChromeProxyService does not implement setIsolatePauseMode #1627

DanTup opened this issue May 26, 2022 · 3 comments
Assignees

Comments

@DanTup
Copy link
Contributor

DanTup commented May 26, 2022

I'm preparing to switch VS Code users over from the debug adapter shipped in Dart-Code to the ones that are now shipping in the Dart+Flutter SDKs. However I found that trying to run Flutter apps on the Chrome device fails with this error:

Oops; flutter has exited unexpectedly: "setIsolatePauseMode: (-32603) setIsolatePauseMode: NoSuchMethodError: Class 'ChromeProxyService' has no instance method 'setIsolatePauseMode' with matching arguments.
Receiver: Instance of 'ChromeProxyService'
Tried calling: setIsolatePauseMode("1", exceptionPauseMode: "Unhandled", shouldPauseOnExit: null)
Found: setIsolatePauseMode(String, {String exceptionPauseMode, bool shouldPauseOnExit}) => Future<Success>
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:38:5)
#1      ChromeProxyService.noSuchMethod (package:dwds/src/services/chrome_proxy_service.dart:1079:18)
#2      ChromeProxyService.setIsolatePauseMode (package:dwds/src/services/chrome_proxy_service.dart:43:7)

I believe the issue is that in dart-lang/sdk@0cad0e7 the debug adapter was switched from setExceptionPauseMode to setIsolatePauseMode and that's not implemented by the proxy.

@bkonyi slightly related - should package:vm_service handle falling back to the old method if the VM Service it's connected to doesn't support it? If not, should the DAP code be switched back to the old method until this is implemented?

@bkonyi
Copy link
Collaborator

bkonyi commented May 31, 2022

@elliette can you take a look at this when you have a chance?

@DanTup ideally, yes, we should fall back onto the deprecated RPCs. Practically, it'll just be easier to fix this in DWDS since most of package:vm_service is autogenerated and we'd need to add a special case in the generation script, which is probably more of a headache than the actual fix.

@bkonyi bkonyi assigned bkonyi and unassigned bkonyi May 31, 2022
@DanTup
Copy link
Contributor Author

DanTup commented May 31, 2022

That sounds reasonable to me, although if there's a chance this can't be fixed in DWDS (and rolled into Flutter) before the next major release, it would be good to consider the options. This is blocking migrating VS Code users over to the new SDK DAPs (which is where any new work will be done, with the old DAPs frozen for anything but major fixes).

Thanks!

@DanTup
Copy link
Contributor Author

DanTup commented Jul 12, 2022

As far as I know, this was completed a while back. Feel free to re-open if there's anything outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants