Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update example #1352

Merged
merged 2 commits into from
Jul 16, 2021
Merged

update example #1352

merged 2 commits into from
Jul 16, 2021

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jul 15, 2021

  • Support the latest dependencies
  • update example

@google-cla google-cla bot added the cla: yes label Jul 15, 2021
grouma
grouma reviewed Jul 15, 2021
View reviewed changes
Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for #1351 to land?

@kevmoo
Copy link
Member Author

kevmoo commented Jul 15, 2021

Should we wait for #1351 to land?

Yup! This is a follow-up

@kevmoo
Copy link
Member Author

kevmoo commented Jul 15, 2021

...should have marked it as a draft, sorry!

@kevmoo kevmoo marked this pull request as draft July 15, 2021 19:35
@kevmoo kevmoo marked this pull request as ready for review July 15, 2021 23:00
@kevmoo kevmoo requested a review from natebosch July 15, 2021 23:00
@kevmoo
Copy link
Member Author

kevmoo commented Jul 16, 2021

Landing on red CI – due to dwds

@kevmoo kevmoo merged commit 8714df3 into master Jul 16, 2021
@kevmoo kevmoo deleted the update_example branch July 16, 2021 00:05
@annagrin annagrin mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma left review comments

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @grouma @natebosch