-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose FrontendServerDdcLibraryBundleStrategyProvider, make vm_service_interface a min constraint, and publish 24.3.0 #2547
Conversation
If we get into the business of using pre-releases in flutter_tools we'll have to pin DWDS and manually roll it, which is a minor annoyance at best. Also, if this interface is going to be changing in a breaking way, we'd have to respect semver and do a major version bump. How much do we expect this interface to change? If we don't expect many breaking changes, we can just include this in a standard release. Otherwise, I'd prefer we get further along on the interface design and rely on local testing with the flutter_tool if that's at all possible. |
It's actually the nested interface that would be breaking ( In that case though, I'd want to modify What do you think about doing all the breaking changes in a single release once we get hot reload working? We can push forward with this minor release (and further minor releases) until then. I'd like to avoid keeping too many changes working only locally with |
Yeah, if we can do all the breaking changes in one release that would be ideal. I just want to avoid having significant churn in public interfaces that require breaking changes to be managed downstream. |
I believe this should be okay to publish then. FYI, the dry-run has a warning:
Do we want to avoid pinning and instead use |
Yeah, giving it more thought we should be safe to no longer pin this. |
Done, thanks! PTAL |
Okay, I believe webdev should be updated in a follow-up PR instead. This is the cadence this package seems to use before the latest release and it seems to line up with the package validation errors I was seeing (where webdev couldn't use the latest package because it hasn't been published yet) e.g.: I don't quite understand how you managed to do both in one PR with the latest release :D, but this way makes the bots happy. I'll submit once CI is green again and upload a PR updating webdev. |
SGTM!
I'll be honest, I don't remember what I did there... :) |
… package_config, pool, pub_semver, shelf, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, test_reflective_loader, watcher, web, web_socket_channel, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/b4b2a43..efe4ee4): efe4ee4 2025-01-02 Devon Carew Update README.md (dart-lang/ecosystem#331) d42c4d2 2024-12-19 Devon Carew [dart_flutter_team_lints] add strict_top_level_inference (dart-lang/ecosystem#328) 38897ae 2024-12-17 Devon Carew add a codeowners file (dart-lang/ecosystem#330) c995170 2024-12-17 Moritz Add more fine grained ignore capabilities to health workflow (dart-lang/ecosystem#329) 5ca7c41 2024-12-17 Moritz Minor fixes to trebuchet (dart-lang/ecosystem#327) d2dd4ce 2024-12-16 Moritz Don't check licenses of generated files (dart-lang/ecosystem#326) 3339020 2024-12-11 Moritz Health fixes (dart-lang/ecosystem#325) b25118a 2024-12-10 Moritz Rename ecosystem testing package to `canary` (dart-lang/ecosystem#323) glob (https://github.com/dart-lang/glob/compare/994191a..eee18d1): eee18d1 2024-12-16 Kevin Moore Fix doc comment in test (dart-lang/glob#101) http (https://github.com/dart-lang/http/compare/c27d6c7..dada989): dada989 2024-12-19 Brian Quinlan Fix a potential exponential backtracking issue when parsing quoted headers (dart-lang/http#1434) 3ce9451 2024-12-18 Kevin Moore http_multi_server: bump lints dep (dart-lang/http#1435) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/f6a7488..2b84a45): 2b84a45 2024-12-17 Moritz Update README.md before archiving (dart-archive/http_multi_server#76) lints (https://github.com/dart-lang/lints/compare/e1d4794..df1f635): df1f635 2024-12-11 Devon Carew update the sdk lower bound to the current stable (dart-lang/lints#220) markdown (https://github.com/dart-lang/markdown/compare/4d5dbc6..19aaded): 19aaded 2025-01-01 dependabot[bot] Bump subosito/flutter-action in the github-actions group (dart-lang/markdown#634) 9fd4375 2024-12-11 Moritz Update README.md before archiving (dart-lang/markdown#633) package_config (https://github.com/dart-lang/package_config/compare/76f2f6c..07097d7): 07097d7 2024-12-11 Moritz Update README.md before archiving (dart-lang/package_config#162) pool (https://github.com/dart-lang/pool/compare/f85209d..bf27900): bf27900 2024-12-11 Moritz Update README.md before archiving (dart-lang/pool#94) pub_semver (https://github.com/dart-lang/pub_semver/compare/8e9fcb9..960f913): 960f913 2024-12-11 Moritz Update README.md before archiving (dart-lang/pub_semver#111) shelf (https://github.com/dart-lang/shelf/compare/2b5b683..8ea524b): 8ea524b 2025-01-01 dependabot[bot] Bump actions/cache from 4.1.2 to 4.2.0 in the github-actions group (dart-lang/shelf#465) 6b8b338 2024-12-17 Kevin Moore shelf_router_generator: bump dependencies (dart-lang/shelf#464) e3975a8 2024-12-09 Devon Carew add more type information to the 'webSocketHandler' method (dart-lang/shelf#463) source_maps (https://github.com/dart-lang/source_maps/compare/198d32b..e5e9d34): e5e9d34 2024-12-11 Moritz Update README.md before archiving (dart-lang/source_maps#99) source_span (https://github.com/dart-lang/source_span/compare/22a243e..e6a3459): e6a3459 2024-12-11 Moritz Update README.md (dart-lang/source_span#121) sse (https://github.com/dart-lang/sse/compare/b97dc3a..b573a1e): b573a1e 2024-12-11 Moritz Update README.md before archiving (dart-archive/sse#121) stack_trace (https://github.com/dart-lang/stack_trace/compare/b660cfa..5fe4cfe): 5fe4cfe 2024-12-20 Moritz Update README.md before archiving (dart-lang/stack_trace#169) stream_channel (https://github.com/dart-lang/stream_channel/compare/71fe6dd..31a3aba): 31a3aba 2024-12-20 Moritz Update README.md before archiving (dart-lang/stream_channel#114) string_scanner (https://github.com/dart-lang/string_scanner/compare/77de235..6921269): 6921269 2024-12-17 Moritz Update README.md (dart-lang/string_scanner#86) term_glyph (https://github.com/dart-lang/term_glyph/compare/9ed8ed9..52677db): 52677db 2024-12-17 Moritz Update README.md before archiving (dart-lang/term_glyph#60) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/408526a..92fa0c5): 92fa0c5 2024-12-20 Moritz Update README.md before archiving (dart-lang/test_descriptor#75) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/faade62..9e35c9e): 9e35c9e 2024-12-12 Moritz Update README.md before archiving (dart-lang/test_reflective_loader#68) watcher (https://github.com/dart-lang/watcher/compare/bc44e6f..7f3b3a3): 7f3b3a3 2024-12-17 Moritz Update README.md before archiving (dart-lang/watcher#174) web (https://github.com/dart-lang/web/compare/bdf112e..af5de5e): af5de5e 2025-01-01 dependabot[bot] Bump actions/cache from 4.1.2 to 4.2.0 in the github-actions group (dart-lang/web#332) b55f343 2024-12-17 Kevin Moore generator: Support the latest package dependencies (dart-lang/web#328) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/7a2039f..a937243): a937243 2024-12-12 Moritz Update README.md before archiving (dart-lang/web_socket_channel#389) webdev (https://github.com/dart-lang/webdev/compare/ab620d1..e72f365): e72f365a 2024-12-23 Srujan Gaddam Expose FrontendServerDdcLibraryBundleStrategyProvider, make vm_service_interface a min constraint, and publish 24.3.0 (dart-lang/webdev#2547) ca963a06 2024-12-23 Srujan Gaddam Handle unnecessary_non_null_assertion and invalid_null_aware_operator (dart-lang/webdev#2554) 36848977 2024-12-20 Nate Biggs [dwds] Add unbatching retry mechanism for failing batched expression evals (dart-lang/webdev#2552) edcfbf12 2024-12-18 Jessy Yameogo Added support for some debugging APIs with the DDC library bundle format - part 4 (dart-lang/webdev#2545) 64655416 2024-12-17 Jessy Yameogo Added support for some debugging APIs with the DDC library bundle format (dart-lang/webdev#2541) b685bb52 2024-12-16 Ben Konyi [ webdev ] Set version to 3.7.1-wip (dart-lang/webdev#2543) 4d0ef258 2024-12-13 Nate Biggs Update pattern test to account for new DDC JS variable naming (dart-lang/webdev#2542) yaml (https://github.com/dart-lang/yaml/compare/2a37272..0406507): 0406507 2024-12-20 Moritz Update README.md before archiving (dart-lang/yaml#175) Change-Id: Ic08b0a166b72113e99624db47a82c55134c17620 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402720 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This is needed to expose this provider to
flutter_tools
. I expect this to be continuously revised however. @bkonyi, should this be a prerelease thatflutter_tools
can use instead of some sort?