chore: set max SDK version to <3.0.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
suggested changes
Jul 17, 2018
analysis_options.yaml
Outdated
| @@ -1,2 +1 @@ | |||
| analyzer: | |||
There was a problem hiding this comment.
Just delete this file entirely if it's not configuring anything.
pubspec.yaml
Outdated
| charcode: ^1.1.0 | ||
| collection: ^1.14.10 | ||
| string_scanner: ^1.0.2 | ||
| source_span: ^1.4.0 |
There was a problem hiding this comment.
Why are you narrowing these constraints?
There was a problem hiding this comment.
(For the reasons I explained yesterday, but I'll add them back)
test/utils.dart
Outdated
| @@ -7,7 +7,7 @@ import 'package:yaml/src/equality.dart' as equality; | |||
| import 'package:yaml/yaml.dart'; | |||
|
|
|||
| /// A matcher that validates that a closure or Future throws a [YamlException]. | |||
| final Matcher throwsYamlException = throwsA(new isInstanceOf<YamlException>()); | |||
| final Matcher throwsYamlException = throwsA(TypeMatcher<YamlException>()); | |||
There was a problem hiding this comment.
I believe there are still frontends in use, at least within Google, that don't yet support optional new.
Also, if you are using it, you should update the SDK constraint to exclude any SDKs where frontends don't use Dart 2 by default.
nex3
reviewed
Jul 17, 2018
pubspec.yaml
Outdated
| path: ">=1.2.0 <2.0.0" | ||
| test: ">=0.12.0 <0.13.0" | ||
| path: ^1.6.1 | ||
| test: ^1.2.0 |
There was a problem hiding this comment.
These dependencies also shouldn't be narrowed.
There was a problem hiding this comment.
Oops, sorry for having missed those. Done
nex3
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @kwalrath @kevmoo