refactor: drop support for the 'call' operator

CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- stricter lint rules.
+- improvements in README.
+
+### Removed
+
+- The overloading of the function call operator —
+  [109](https://github.com/dartoos-dev/eo_color/issues/109) **BREAKIN CHANGE**.
+
 ## [1.1.9] - 2021-08-06
 
 ### Changed

README.md

@@ -53,8 +53,8 @@ Likewise, there are commands for retrieving lighter and darker shades.
 - shades of grey darker than the primary shade: `Grey.bitDarker()`,
   `Grey.darker()`, `Grey.dark()`, or `Grey.veryDark()` for the darkest shade.
 
-With the exception of the colors black and white, the same command patterns (light,
-lighter, dark, very dark, etc.) also apply to all other colors.
+With the exception of the colors black and white, the same command patterns
+(light, lighter, dark, very dark, etc.) also apply to all other colors.
 
 ## Getting Started
 
@@ -67,11 +67,13 @@ three main interfaces are `Palette`, `Swatch`, and `Gradient`.
 It represents color palettes from which a color can be selected.
 
 Typically, subclasses of the _Palette_ interface provide named constructors by
-which the desired color is selected — to be retrieved later via the `color` property.
+which the desired color is selected — to be retrieved later via the `color`
+property.
 
-For instance, the command `Blue()` retrieves the primary shade of blue and is equivalent
-to the Flutter command `Colors.blue.shade500`. Similarly, `Blue.veryLight()` is equivalent
-to `Colors.blue.shade50`; `Blue.veryDark()`, to `Colors.grey.shade900`; and so on.
+For instance, the command `Blue()` retrieves the primary shade of blue and is
+equivalent to the Flutter command `Colors.blue.shade500`. Similarly,
+`Blue.veryLight()` is equivalent to `Colors.blue.shade50`; `Blue.veryDark()`, to
+`Colors.grey.shade900`; and so on.
 
 The code snippet below demonstrates how to build a bluish Flutter Container
 widget using the `Blue` color class.
@@ -104,8 +106,8 @@ The table below contains the relationship between the Material Design indexes
     such as _Amber_, _Green_, _Red_, etc.
   - On the other hande, the **"Accent"** column refers to classes that represent
     accent colors such as _AmberAccent_, _GreenAccent_, _RedAccent_, and so on.
-  - Finally, **"()"** refers to the default constructor, which in turn represents
-    the primary shade of the color class it belongs to.
+  - Finally, **"()"** refers to the default constructor, which in turn
+    represents the primary shade of the color class it belongs to.
 
 | Index | Normal     | Accent |
 | :---- | ---------- | :----- |
@@ -206,8 +208,8 @@ For a complete list of gradients:
 ## Demo application
 
 The demo application provides a fully working example, focused on demonstrating
-exactly three color palettes in action: BlueGrey, Grey, and Brown. You can take
-the code in this demo and experiment with it.
+exactly three color palettes in action: **BlueGrey**, **Grey**, and **Brown**.
+You can take the code in this demo and experiment with it.
 
 To run the demo application:
 

lib/src/gradient_immu.dart

@@ -15,8 +15,4 @@ abstract class GradientImmu extends SwatchBase implements Gradient {
   /// An **immutable list** of position-dependent colors — a color gradient.
   @override
   List<Color> get colors => List.unmodifiable(super.colors);
-
-  /// Forwards to [colors].
-  @override
-  List<Color> call() => colors;
 }

lib/src/palette_rgb.dart

@@ -34,7 +34,4 @@ abstract class PaletteRGB implements Palette {
   /// The rgb color.
   @override
   Color get color => Color(_value);
-
-  /// Convenience overloading; forwards to [color].
-  Color call() => color;
 }

lib/src/swatch_base.dart

@@ -16,7 +16,4 @@ abstract class SwatchBase implements Swatch {
   /// A new lazy [Iterable] of [Color].
   @override
   Iterable<Color> get colors => _palettes.map((palette) => palette.color);
-
-  /// Forwards to [colors].
-  Iterable<Color> call() => colors;
 }

test/gradient_immu_test.dart

@@ -25,7 +25,6 @@ void main() {
     test('single', () {
       const singleElem = GradTest.single();
       expect(singleElem.colors.length, 1);
-      expect(singleElem().first, aGrey.first.color);
     });
     test('many', () {
       const manyElems = GradTest.many();

test/material/amber/amber_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const AmberAccent.dark().color, Colors.amberAccent.shade700);
     });
-    test('call method', () {
-      const amberAccent = AmberAccent();
-      expect(amberAccent(), amberAccent.color);
-    });
   });
 }

test/material/amber/amber_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Amber.veryDark().color, Colors.amber.shade900);
     });
-    test('call method', () {
-      const amber = Amber();
-      expect(amber(), amber.color);
-    });
   });
 }

test/material/black/black_test.dart

@@ -26,9 +26,5 @@ void main() {
     test('12% opacity', () {
       expect(const Black.opacity12().color, Colors.black12);
     });
-    test('call method', () {
-      const black = Black();
-      expect(black(), black.color);
-    });
   });
 }

test/material/blue/blue_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const BlueAccent.dark().color, Colors.blueAccent.shade700);
     });
-    test('call method', () {
-      const blueAccent = BlueAccent();
-      expect(blueAccent(), blueAccent.color);
-    });
   });
 }

test/material/blue/blue_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Blue.veryDark().color, Colors.blue.shade900);
     });
-    test('call method', () {
-      const blue = Blue();
-      expect(blue(), blue.color);
-    });
   });
 }

test/material/blue_grey/blue_grey_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const BlueGrey.veryDark().color, Colors.blueGrey.shade900);
     });
-    test('call method', () {
-      const blueGrey = BlueGrey();
-      expect(blueGrey(), blueGrey.color);
-    });
   });
 }

test/material/brown/brown_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Brown.veryDark().color, Colors.brown.shade900);
     });
-    test('call method', () {
-      const brown = Brown();
-      expect(brown(), brown.color);
-    });
   });
 }

test/material/cyan/cyan_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const CyanAccent.dark().color, Colors.cyanAccent.shade700);
     });
-    test('call method', () {
-      const cyanAccent = CyanAccent();
-      expect(cyanAccent(), cyanAccent.color);
-    });
   });
 }

test/material/cyan/cyan_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Cyan.veryDark().color, Colors.cyan.shade900);
     });
-    test('call method', () {
-      const cyan = Cyan();
-      expect(cyan(), cyan.color);
-    });
   });
 }

test/material/deep_orange/deep_orange_accent_test.dart

@@ -26,9 +26,5 @@ void main() {
         Colors.deepOrangeAccent.shade700,
       );
     });
-    test('call method', () {
-      const deepOrangeAccent = DeepOrangeAccent();
-      expect(deepOrangeAccent(), deepOrangeAccent.color);
-    });
   });
 }

test/material/deep_orange/deep_orange_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const DeepOrange.veryDark().color, Colors.deepOrange.shade900);
     });
-    test('call method', () {
-      const deepOrange = DeepOrange();
-      expect(deepOrange(), deepOrange.color);
-    });
   });
 }

test/material/deep_purple/deep_purple_accent_test.dart

@@ -26,9 +26,5 @@ void main() {
         Colors.deepPurpleAccent.shade700,
       );
     });
-    test('call method', () {
-      const deepPurpleAccent = DeepPurpleAccent();
-      expect(deepPurpleAccent(), deepPurpleAccent.color);
-    });
   });
 }

test/material/deep_purple/deep_purple_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const DeepPurple.veryDark().color, Colors.deepPurple.shade900);
     });
-    test('call method', () {
-      const deepPurple = DeepPurple();
-      expect(deepPurple(), deepPurple.color);
-    });
   });
 }

test/material/green/green_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const GreenAccent.dark().color, Colors.greenAccent.shade700);
     });
-    test('call method', () {
-      const greenAccent = GreenAccent();
-      expect(greenAccent(), greenAccent.color);
-    });
   });
 }

test/material/green/green_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Green.veryDark().color, Colors.green.shade900);
     });
-    test('call method', () {
-      const green = Green();
-      expect(green(), green.color);
-    });
   });
 }

test/material/grey/grey_test.dart

@@ -41,9 +41,5 @@ void main() {
     test('very dark', () {
       expect(const Grey.veryDark().color, Colors.grey.shade900);
     });
-    test('call method', () {
-      const grey = Grey();
-      expect(grey(), grey.color);
-    });
   });
 }

test/material/indigo/indigo_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const IndigoAccent.dark().color, Colors.indigoAccent.shade700);
     });
-    test('call method', () {
-      const indigoAccent = IndigoAccent();
-      expect(indigoAccent(), indigoAccent.color);
-    });
   });
 }

test/material/indigo/indigo_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Indigo.veryDark().color, Colors.indigo.shade900);
     });
-    test('call method', () {
-      const indigo = Indigo();
-      expect(indigo(), indigo.color);
-    });
   });
 }

test/material/light_blue/light_blue_accent_test.dart

@@ -26,9 +26,5 @@ void main() {
         Colors.lightBlueAccent.shade700,
       );
     });
-    test('call method', () {
-      const lightBlueAccent = LightBlueAccent();
-      expect(lightBlueAccent(), lightBlueAccent.color);
-    });
   });
 }

test/material/light_blue/light_blue_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const LightBlue.veryDark().color, Colors.lightBlue.shade900);
     });
-    test('call method', () {
-      const lightBlue = LightBlue();
-      expect(lightBlue(), lightBlue.color);
-    });
   });
 }

test/material/light_green/light_green_accent_test.dart

@@ -26,9 +26,5 @@ void main() {
         Colors.lightGreenAccent.shade700,
       );
     });
-    test('call method', () {
-      const lightGreenAccent = LightGreenAccent();
-      expect(lightGreenAccent(), lightGreenAccent.color);
-    });
   });
 }

test/material/light_green/light_green_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const LightGreen.veryDark().color, Colors.lightGreen.shade900);
     });
-    test('call method', () {
-      const lightGreen = LightGreen();
-      expect(lightGreen(), lightGreen.color);
-    });
   });
 }

test/material/lime/lime_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const LimeAccent.dark().color, Colors.limeAccent.shade700);
     });
-    test('call method', () {
-      const limeAccent = LimeAccent();
-      expect(limeAccent(), limeAccent.color);
-    });
   });
 }

test/material/lime/lime_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Lime.veryDark().color, Colors.lime.shade900);
     });
-    test('call method', () {
-      const lime = Lime();
-      expect(lime(), lime.color);
-    });
   });
 }

test/material/orange/orange_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const OrangeAccent.dark().color, Colors.orangeAccent.shade700);
     });
-    test('call method', () {
-      const orangeAccent = OrangeAccent();
-      expect(orangeAccent(), orangeAccent.color);
-    });
   });
 }

test/material/orange/orange_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Orange.veryDark().color, Colors.orange.shade900);
     });
-    test('call method', () {
-      const orange = Orange();
-      expect(orange(), orange.color);
-    });
   });
 }

test/material/pink/pink_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const PinkAccent.dark().color, Colors.pinkAccent.shade700);
     });
-    test('call method', () {
-      const pinkAccent = PinkAccent();
-      expect(pinkAccent(), pinkAccent.color);
-    });
   });
 }

test/material/pink/pink_test.dart

@@ -35,9 +35,5 @@ void main() {
     test('very dark', () {
       expect(const Pink.veryDark().color, Colors.pink.shade900);
     });
-    test('call method', () {
-      const pink = Pink();
-      expect(pink(), pink.color);
-    });
   });
 }

test/material/purple/purple_accent_test.dart

@@ -17,9 +17,5 @@ void main() {
     test('dark', () {
       expect(const PurpleAccent.dark().color, Colors.purpleAccent.shade700);
     });
-    test('call method', () {
-      const purpleAccent = PurpleAccent();
-      expect(purpleAccent(), purpleAccent.color);
-    });
   });
 }