Address reviewer feedback.

Signed-off-by: Addisu Z. Taddese <[email protected]>
dartsim · Dec 18, 2021 · bc78a37 · bc78a37
1 parent b026553
commit bc78a37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/dart/collision/CollisionGroup.hpp b/dart/collision/CollisionGroup.hpp
@@ -218,18 +218,18 @@ class CollisionGroup
   /// template.
   void unsubscribeFrom();
 
-  // Check if this is subscribed to bodyNode and the other sources
+  /// Check if this is subscribed to bodyNode and the other sources
   template <typename... Others>
   bool isSubscribedTo(
       const dynamics::BodyNode* bodyNode, const Others*... others);
 
-  // Check if this is subscribed to skeleton and the other sources
+  /// Check if this is subscribed to skeleton and the other sources
   template <typename... Others>
   bool isSubscribedTo(
       const dynamics::Skeleton* skeleton, const Others*... others);
 
-  // Return true. This function is for terminating the recursive variadic
-  // template
+  /// Return true. This function is for terminating the recursive variadic
+  /// template
   bool isSubscribedTo();
 
   /// Return true if this CollisionGroup contains shapeFrame

diff --git a/unittests/unit/test_CollisionGroups.cpp b/unittests/unit/test_CollisionGroups.cpp
@@ -312,7 +312,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription)
       boxShape);
 
   // Needed to update subscribtions
-  world->step(1);
+  world->step();
 
   EXPECT_TRUE(group->hasShapeFrame(sn));
   const auto* skel_A_ptr = skel_A.get();
@@ -322,7 +322,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription)
   world->removeSkeleton(skel_A);
   world->removeSkeleton(skel_B);
 
-  world->step(1);
+  world->step();
 
   EXPECT_FALSE(group->hasShapeFrame(sn));
   EXPECT_FALSE(group->isSubscribedTo(skel_A_ptr));