Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EulerJoint::AxisOrder enumeration is deceptive #321

Closed
mxgrey opened this issue Jan 27, 2015 · 1 comment · Fixed by #323
Closed

EulerJoint::AxisOrder enumeration is deceptive #321

mxgrey opened this issue Jan 27, 2015 · 1 comment · Fixed by #323
Milestone

Comments

@mxgrey
Copy link
Member

mxgrey commented Jan 27, 2015

There are currently 4 enumerations for EulerJoint::AxisOrder, but only two of those enumerations appear to be supported in the code. Specifically, EulerJoint::updateLocalTransform(), EulerJoint::updateLocalJacobian(), and EulerJoint::updateLocalJacobianDeriv() only handle AO_XYZ and AO_ZYX in their code.

To me it seems like any axis orderings that are not supported should not be enumerated, or else the user will be left thinking that they can be used. If we extend support to those orderings in the future, I don't think there's any issue with adding them back into the enumeration at that time.

@jslee02
Copy link
Member

jslee02 commented Jan 28, 2015

Good point. Created PR for this.

jslee02 added a commit that referenced this issue Jan 29, 2015
[Fix #321] Remove unsupported axis orders of EulerJoint
@jslee02 jslee02 added this to the Release DART 5.0 milestone Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants