Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_osx: try removing sudo from brew commands #1426

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

scpeters
Copy link
Collaborator

The osx CI is failing in #1424 complaining about running as root:

Error: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.

So I've removed the sudo calls from the install_osx script and CI is now passing.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #1426 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage      58%   57.99%   -0.02%     
==========================================
  Files         412      412              
  Lines       29794    29794              
==========================================
- Hits        17283    17280       -3     
- Misses      12511    12514       +3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.16% <0%> (-0.17%) ⬇️

@jslee02 jslee02 merged commit 9192c38 into master Nov 17, 2019
@jslee02 jslee02 deleted the osx_no_sudo branch November 17, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants